Skip to content

Conversation

@apazos
Copy link
Contributor

@apazos apazos commented Apr 16, 2025

No description provided.

@apazos
Copy link
Contributor Author

apazos commented Apr 16, 2025

@cmuellner, just noted we missed to alphabetize the lists in the approved PR #69

@cmuellner
Copy link
Collaborator

Thanks for catching this!

There are two tables:

  • vendor, prefix, link -> sorted by prefix
  • vendor, extension, link -> sorted by vendor

The sort order seems arbitrary.
It would be better to sort both by vendor or by prefix/extension.

Also, since the focus is on the prefix/extension, we could swap the first two columns of the table.

@apazos
Copy link
Contributor Author

apazos commented Apr 17, 2025

I think that ordering vendor extensions by name makes the table less readable due to its length.
Might be best to just order both by vendor.

@apazos apazos changed the title Alphabetized the prefix list by prefix an extensions list by vendor name Alphabetized the prefix and extensions lists by vendor name Apr 17, 2025
@cmuellner
Copy link
Collaborator

I think that ordering vendor extensions by name makes the table less readable due to its length. Might be best to just order both by vendor.

I can see pros/cons for both orderings.
If needed, a Ctrl + F will help to find entries.

Thank you for ordering both tables the same way!

@cmuellner cmuellner merged commit 3212b2e into riscv-non-isa:main Apr 17, 2025
@apazos apazos deleted the vendor-mips branch May 8, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants