This repository was archived by the owner on Sep 2, 2025. It is now read-only.
embedded-hal v1.0.0-alpha.8 support #45
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 31, 2022
|
I'm fine with a mention in the commit message. Thanks. :) |
almindor
force-pushed
the
e-h-1.0.0-alpha.8
branch
from
628f4a6 to
e8e62a7
Compare
Added in the commit msg for alpha.7 support |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for embedded-hal v1.0.0-alpha.8 by refactoring existing SPI device implementation into using the new traits.
Tested with write only so far.
Requires:
riscv-rust/e310x#26
rust-embedded/riscv-rt#101
rust-embedded/riscv#106
Based off of @ahmedcharles work in #42 which I kind of botched up by merging to master too soon. @ahmedcharles if you feel strongly about the contribution loss here please ping me here and we can figure out how to best combine these changes so you get the proper credit for the
alpha.7changes.