-
Notifications
You must be signed in to change notification settings - Fork 26
README: update to new governance structure #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
||
[CoC]: CODE_OF_CONDUCT.md | ||
[team]: https://github.com/rust-embedded/wg#the-risc-v-team | ||
[risc-v team]: https://github.com/rust-embedded/wg#the-risc-v-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this link is wrong because it points to the EWG team, not the riscv-rust team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's possible that I'm confused about the structures here. I mean, I was accepted to something called riscv-rust, but my name is not under that link.
What would you suggest to do instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no RISC-V team in this organization, so if you intend to change the owner of the repo (which seems to be the right thing to do), then the link should point to the organization, not the team.
Also it might be a good idea to change the authors
parameter in Cargo.toml
, although I have no idea what email address to put there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought the RISC-V organization was a team within the rust-embedded organization. Is that not the case?
I updated the author field. I think the copyright notice also needs an entry for the new team, but I'm not sure if I should attribute it to Rust-RISC-V or the gd32vf103 group directly. Suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, the riscv-rust organization is an independent organization (like stm32-rs and many others). The rust-embedded organization has its own RISC-V team, which has some intersection with the riscv-rust org in terms of members, but that's it.
I think the copyright notice also needs an entry for the new team, but I'm not sure if I should attribute it to Rust-RISC-V or the gd32vf103 group directly. Suggestions?
I'd use the organization there (also in Cargo.toml). I see the team mainly as a maintenance unit that also provides some flexibility (enabling adding and removing people if needed, splitting and merging teams and so on). But I don't have a strong opinion on this, either option may work just fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took your advice.
83d6fc4
to
94c99ca
Compare
Cargo.toml
Outdated
name = "gd32vf103xx-hal" | ||
version = "0.5.0" | ||
authors = ["The RISC-V Team <risc-v@teams.rust-embedded.org>"] | ||
authors = ["rust-riscv"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
authors = ["rust-riscv"] | |
authors = ["The riscv-rust organization"] |
README.md
Outdated
## License | ||
|
||
Copyright 2019 [RISC-V team][team] | ||
Copyright 2025 [rust-riscv](https://github.com/riscv-rust/teams) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copyright 2025 [rust-riscv](https://github.com/riscv-rust/teams) | |
Copyright 2025 [The riscv-rust organization](https://github.com/riscv-rust/teams) |
The RISC-V team is not the closest structure responsible for this crate. Now it's the special gd32vf103 team.
Update that and link to the riscv-teams repository.