feat(schema): convert param 'when' to full extension req cond (#751)

Needed to represent cross-extension conditions, rather than assuming
a parameter would only be dependent on the version of the defining
extension.

Author: dhower-qc

Rakefile

@@ -272,7 +272,7 @@ namespace :test do
 
   task schema: "#{$root}/.stamps/resolve-_.stamp" do
     puts "Checking arch files against schema.."
-    Architecture.new("#{$root}/gen/resolved_arch/_").validate(show_progress: true)
+    cfg_arch_for("_").validate(show_progress: true)
     puts "All files validate against their schema"
   end
 

arch/ext/Sm.yaml

@@ -404,6 +404,7 @@ params:
       minimum: 0
       maximum: 0xFFFFFFFFFFFFFFFF
     when:
+      name: Sm
       version: ">= 1.12.0"
   PMA_GRANULARITY:
     description: |

arch/isa/globals.isa

@@ -1242,7 +1242,7 @@ function access_check {
   }
   body {
     # check if this is a valid physical address
-    if (paddr > ((1 << PHYS_ADDR_WIDTH) - access_size)) {
+    if (paddr > ((1 `<< PHYS_ADDR_WIDTH) - access_size)) {
       raise(fault_type, from_mode, vaddr);
     }
 

backends/cfg_html_doc/templates/ext.adoc.erb

@@ -36,7 +36,7 @@ Implemented Version:: <%= ext_version.version_str %>
 
 <%= ext.description %>
 
-<%- insts = cfg_arch.transitive_implemented_instructions.select { |i| i.definedBy == ext.name || i.definedBy.include?(ext.name) } -%>
+<%- insts = ext.instructions -%>
 <%- unless insts.empty? -%>
 == Instructions
 

backends/common_templates/adoc/csr.adoc.erb

@@ -100,7 +100,7 @@ written value:
 ----
 <%- csr.fields.each do |field| -%>
 <%- if field.has_custom_sw_write? -%>
-<%= field.name %> = <%= field["sw_write(csr_value)"] %>
+<%= field.name %> = <%= field.data["sw_write(csr_value)"] %>
 <%- else -%>
 <%= field.name %> = csr_value.<%= field.name %>
 <%- end -%>

backends/manual/templates/instruction.adoc.erb

@@ -66,7 +66,7 @@ Sail::
 +
 [source,sail]
 ----
-<%= inst.fix_entities(inst["sail()"]) %>
+<%= inst.fix_entities(inst.data["sail()"]) %>
 ----
 <%- end -%>
 ====

backends/portfolio/tasks.rake

@@ -7,11 +7,7 @@ require_relative "#{$lib}/idl/passes/gen_adoc"
 
 # @return [Architecture]
 def pf_create_arch
-  # Ensure that unconfigured resolved architecture called "_" exists.
-  Rake::Task["#{$root}/.stamps/resolve-_.stamp"].invoke
-
-  # Create architecture object using the unconfigured resolved architecture called "_".
-  Architecture.new($root / "gen" / "resolved_arch" / "_")
+  cfg_arch_for("_")
 end
 
 # @param portfolio_grp_with_arch [PortfolioGroup] Contains one or more Portfolio objects that have an arch (not a cfg_arch).

backends/portfolio/templates/csr_appendix.adoc.erb

@@ -162,7 +162,7 @@ written value:
 ----
 <% csr.possible_fields.each do |field| -%>
 <% if field.has_custom_sw_write? -%>
-<%= field.name %> = <%= field["sw_write(csr_value)"] %>
+<%= field.name %> = <%= field.data["sw_write(csr_value)"] %>
 <% else -%>
 <%= field.name %> = csr_value.<%= field.name %>
 <% end -%>

backends/portfolio/templates/inst_appendix.adoc.erb

@@ -114,7 +114,7 @@ RV64::
 
 [source,sail]
 ----
-<%= inst["sail()"] %>
+<%= inst.data["sail()"] %>
 ----
 <% end -%>
 

lib/arch_obj_models/certificate.rb

@@ -173,11 +173,7 @@ def all_in_scope_params
         param = ext.params.find { |p| p.name == param_name }
         raise "There is no param '#{param_name}' in extension '#{ext_name}" if param.nil?
 
-        next unless ext.versions.any? do |ext_ver|
-          ver_req = ext_data["version"] || ">= #{ext.min_version.version_spec}"
-          ExtensionRequirement.new(ext_name, ver_req, arch: @arch).satisfied_by?(ext_ver) &&
-            param.defined_in_extension_version?(ext_ver)
-        end
+        next unless param.when.could_be_satisfied_by_ext_reqs?(in_scope_ext_reqs)
 
         @all_in_scope_params << InScopeParameter.new(param, param_data["schema"], param_data["note"])
       end
@@ -208,9 +204,7 @@ def in_scope_params(ext_req)
       param = ext.params.find { |p| p.name == param_name }
       raise "There is no param '#{param_name}' in extension '#{ext_req.name}" if param.nil?
 
-      next unless ext.versions.any? do |ext_ver|
-        ext_req.satisfied_by?(ext_ver) && param.defined_in_extension_version?(ext_ver)
-      end
+      next unless param.when.could_be_satisfied_by_ext_reqs?(in_scope_ext_reqs)
 
       params << InScopeParameter.new(param, param_data["schema"], param_data["note"])
     end
@@ -229,11 +223,6 @@ def all_out_of_scope_params
       ext.params.each do |param|
         next if all_in_scope_params.any? { |c| c.param.name == param.name }
 
-        next unless ext.versions.any? do |ext_ver|
-                      ext_req.satisfied_by?(ext_ver) &&
-                      param.defined_in_extension_version?(ext_ver)
-                    end
-
         @all_out_of_scope_params << param
       end
     end