Skip to content

fix: missing Assembly section for instructions with no variables #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+4 −6
Draft

fix: missing Assembly section for instructions with no variables #1212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1364e2e
Initial plan
Copilot Oct 28, 2025
a7c274d
Fix missing Assembly section for instructions with no variables
Copilot Oct 28, 2025
48755cd
Fix missing Assembly section and clean up trailing whitespace in all …
Copilot Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/common_templates/adoc/inst.adoc.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Synopsis::

Mnemonic::
----
<%= inst.name %> <%= inst.assembly.gsub('x', 'r') %>
<%= "#{inst.name} #{inst.assembly.gsub('x', 'r')}".strip %>
----

Encoding::
Expand Down
2 changes: 1 addition & 1 deletion backends/ext_pdf_doc/templates/ext_pdf.adoc.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ The following <%= ext.instructions.size %> instructions are affected by this ext
<%- inst_list.each do |i| -%>
| <%= i.rv32? ? "&#x2713;" : "" %>
| <%= i.rv64? ? "&#x2713;" : "" %>
| `<%= i.name %> <%= i.assembly.gsub("x", "r").strip %>`
| `<%= "#{i.name} #{i.assembly.gsub('x', 'r')}".strip %>`
| xref:insns-<%= i.name.gsub('.', '_') %>[<%= i.long_name %>]
<%- if versions.size > 1 -%>
| <%= ext.versions.map { |v| i.defined_by_condition.possibly_satisfied_by?(v) ? "&#x2713;" : "" }.join(" | ") %>
Expand Down
4 changes: 1 addition & 3 deletions backends/instructions_appendix/templates/instructions.adoc.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,9 @@
Synopsis::
<%= inst.long_name %>

<%- if inst.assembly.to_s.strip != "" -%>
Assembly::
<%= inst.fix_entities("#{inst.name.downcase} #{inst.assembly}") %>
<%= inst.fix_entities("#{inst.name.downcase} #{inst.assembly}").strip %>

<%- end -%>
Encoding::
<%- if inst.multi_encoding? -%>
[NOTE]
Expand Down
2 changes: 1 addition & 1 deletion backends/manual/templates/instruction.adoc.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ This instruction must have data-independent timing when extension `Zkt` is enabl

== Assembly format

`<%= inst.name %> <%= inst.assembly.gsub('x', 'r') %>`
`<%= "#{inst.name} #{inst.assembly.gsub('x', 'r')}".strip %>`

== Decode Variables

Expand Down
Loading