Move mandatory privilege mode option from CRD family to CRD #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhower-qc
requested changes
Oct 24, 2024
| family: MockCRDFamily | ||
|
|
||
| mandatory_priv_modes: | ||
| - M,U |
Collaborator
There was a problem hiding this comment.
Assuming you want this to be an array, this should be:
mandatory_priv_modes:
- M
- Uor
mandatory_priv_modes: [M,U]What you've written is an array with one string:
["M,U"]| * Red fields are defined by the RISC-V ISA but not present | ||
| * [green]#Green fields# are present in the associated CRD. | ||
| * [red]#Red fields# are defined by the RISC-V ISA but not required in the associated CRD. | ||
| * [silver]#Grey fields# are reserved for future use by RISC-V (AKA WPRI). Software should ignore the values read from |
|
|
||
| # @return [true/false] | ||
| def m_mode? | ||
| mandatory_priv_modes.include?('M') |
Collaborator
There was a problem hiding this comment.
Just a note: you don't need to change this. You lucked out that String and Array both have an include? method.
Collaborator
|
Not to be a pain, but my preference is for commit messages to have subject lines that reflect what is being changed, rather than "Fixes #181". So, something like "Move mandatory privilege mode option from CRD family to CRD" (if I understand the changes correctly). It makes the |
dhower-qc
changed the title
…ttps://github.com/riscv-software-src/riscv-unified-db into :181-move-priv-modes-present-from-crd-family-to-crd
Collaborator
Author
|
Premature PR |
james-ball-qualcomm
deleted the
181-move-priv-modes-present-from-crd-family-to-crd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #181