Skip to content

restrict date regex to only valid months; fixes #310 #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 2, 2024
Merged

restrict date regex to only valid months; fixes #310 #311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67554d9
restrict date regex to only valid months; fixes #310
kbroch-rivosinc Nov 23, 2024
66bdfc6
Merge branch 'main' into dev/kbroch/regex-ratif-date-change
dhower-qc Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion schemas/ext_schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@
},
"ratification_date": {
"oneOf": [
{"type": "string", "pattern": "^20[0-9][0-9]-[0-9][0-9]$", "$comment": "When ratification date is known" },
{"type": "string", "pattern": "^20[0-9][0-9]-(0[1-9]|1[0-2])$", "$comment": "When ratification date is known",
"description": "A specific year and month in YYYY-MM format", "examples": ["2019-01", "2024-12"] },
{"type": "string", "pattern": "^unknown$", "$comment": "When ratification date is unknown" },
{"type": "null", "$comment": "When version isn't ratified" }
]
Expand Down
5 changes: 3 additions & 2 deletions schemas/schema_defs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
"date": {
"type": "string",
"format": "date",
"description": "A specific day in YYYY-MM-DD format, for example 2018-11-13"
"description": "A specific day in YYYY-MM-DD format",
"examples": ["2018-11-13", "2024-12-31"]
},
"extension_name": {
"type": "string",
Expand All @@ -91,7 +92,7 @@
},
"requirement_string": {
"type": "string",
"pattern": "^((>=)|(>)|(~>)|(<)|(<=)|(=))\\s*[0-9]+(\\.[0-9]+(\\.[0-9]+(-[a-fA-F0-9]+)?)?)?$"
"pattern": "^((>=)|(>)|(~>)|(<)|(<=)|(=))?\\s*[0-9]+(\\.[0-9]+(\\.[0-9]+(-[a-fA-F0-9]+)?)?)?$"
},
"version_requirements": {
"description": "A (set of) version requirements",
Expand Down