Big beautiful refactoring #386
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… updated $ref syntax (matching certificates).
…software-src/riscv-unified-db into big-beautiful-refactoring
…if a different design was passed to it which seems bizzare since it goes out of its way to support having a different type for different designs. So, I modified it to work like the type cache in ast and do what I think it wanted to do in the first place.
…software-src/riscv-unified-db into big-beautiful-refactoring
…ke it clearer the return type since I found bugs in the code related to this.
…n't have (i.e. in @config). Also true for implemented and prohibited.
…ns, CSRs, and traps that aren't in the configuration). Still need to fix traps and interrupts.
…chitecture inheritence from Architecture.
…seems to have failed incorrectly).
dhower-qc
reviewed
Mar 3, 2025
Collaborator
There was a problem hiding this comment.
With Ruby's Duck Typing, interface classes like these aren't necessary for mocking. Any class that responds to the function you are testing works -- the interface doesn't add anything.
We should get rid of IDesign.
Collaborator
There was a problem hiding this comment.
I'm still struggling with the need for this class. It has the same methods as a ConfiguredArchitecture; what is it adding? Seems like the following works just as well:
Config < PartialConfig \
< ConfiguredArchitecture < Portfolio < {Profile, Certificate}
Architecture /
Remind me what the benefit is?
| attr_reader :name | ||
|
|
||
| # @return [Integer] 32 for RV32I or 64 for RV64I | ||
| attr_reader :base |
Collaborator
There was a problem hiding this comment.
How can base be in the generic Architecture class? Base is a parameter.
Merged
Collaborator
|
can this be closed, assuming it's covered by #584 ? |
Collaborator
Author
|
Included in #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #385