Reduce duplicate code between various backend templates #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Ooops, meant to make this a draft PR. |
…file & CRD tasks.rake into it.
james-ball-qualcomm
changed the title
…ios. Also created include_erb method in PortfolioDesign that invokes ERB partial templates with a standard set of locals.
Collaborator
Author
|
I'd like to get this merged into main. |
Collaborator
|
Not to be a pain, but it would be nice if each commit was reasonably understandable standalone:
I'm looking at "One more fix" and "Finished" in particular. ;-) We don't have contribution guidelines, but we probably should start thinking about that. The generations that follow us might need to understand why we made the choices we made. :-) |
Collaborator
Author
|
Included in #584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.