Removing unratified RV128 instructions #451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhower-qc
requested review from
AFOliveira,
ThinkOpenly and
james-ball-qualcomm
ThinkOpenly
approved these changes
Feb 1, 2025
Collaborator
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
Seems fine. If RV128/C was approved, do we have the ability to conditionally include these instructions?
AFOliveira
approved these changes
Feb 3, 2025
Collaborator
The UDB instruction schema has a field |
Collaborator
Author
|
Yes, in theory the schema supports RV128. The backend is another story...for better or worse, there are a ton of places we assume 64 is the largest XLEN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #446