Skip to content

Update code for fcvt.s.w, fcvt.s.wu, fadd and fsub #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ShashankVM merged 6 commits into from
Mar 3, 2025
Merged

Update code for fcvt.s.w, fcvt.s.wu, fadd and fsub #461

ShashankVM merged 6 commits into from
Mar 3, 2025
+60 −18

Conversation

@ShashankVM
Copy link
Collaborator

@ShashankVM ShashankVM commented Feb 11, 2025 •
edited
Loading

fcvt.s.w

  • Removed the inline code and replaced it with function call

fcvt.s.wu

  • Added instruction operation, long name and description fields for this file.

fadd

  • Added check_f_ok function call before doing the operation.

fsub

  • Added check_f_ok function call before doing the operation.

Progress towards #209

dhower-qc
dhower-qc requested changes Feb 11, 2025
View reviewed changes
@ShashankVM ShashankVM marked this pull request as draft February 12, 2025 14:38
@ShashankVM ShashankVM marked this pull request as ready for review February 12, 2025 14:42
@ShashankVM ShashankVM changed the title Update code for fcvt.s.w, fadd and fsub Update code for fcvt.s.w, fcvt.s.wu, fadd and fsub Feb 12, 2025
@ShashankVM ShashankVM requested a review from dhower-qc February 12, 2025 15:37
@ShashankVM ShashankVM enabled auto-merge February 12, 2025 17:12
@ShashankVM ShashankVM added this pull request to the merge queue Mar 3, 2025
Merged via the queue into riscv-software-src:main with commit 8ea63d6 Mar 3, 2025
7 checks passed
ayosher pushed a commit that referenced this pull request Mar 5, 2025
@ShashankVM @ayosher
Update code for fcvt.s.w, fcvt.s.wu, fadd and fsub (#461)
7a3822d 
* Committing after removing trailing whitespace

* Fix rm value to take from instruction encoding

* autochange by end-of-file-fixer

* Add missing close bracket
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhower-qc dhower-qc dhower-qc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ShashankVM @dhower-qc