-
Notifications
You must be signed in to change notification settings - Fork 78
Add Zclsd extension YAML #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zclsd extension YAML #577
Conversation
d37b1aa to
e322a4d
Compare
e322a4d to
abc4553
Compare
02d3cc1 to
fb4e75d
Compare
fb4e75d to
7a01aee
Compare
dhower-qc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments apply to all the instructions.
7a01aee to
ab9a65c
Compare
875af8d to
3e10a3f
Compare
3e10a3f to
d5263f9
Compare
d5263f9 to
addf131
Compare
addf131 to
804d7cb
Compare
|
@Shehrozkashif, did you see that there are "conflicts that must be resolved"? |
|
@ThinkOpenly yes I can see the conflict Should I keep the new logic, the main branch version, or try to merge both? |
I know your comment is intended to Paul, but I would say to try to manually merge and see what has been done. If it is the work you have been doing, probably just review the upstream changes, and if you agree, keep them, if you dont agree just push changes to them |
|
Thanks for the advice, @AFOliveira! I'll go ahead and manually merge the changes and review the differences. If the upstream changes align with my work, I’ll keep them; if not, I’ll make the necessary adjustments. Appreciate the help! |
If in doubt, use |
Co-authored-by: Paul Clarke <[email protected]> Signed-off-by: Shehroz Kashif <[email protected]>
Signed-off-by: Shehroz Kashif <[email protected]>
62b0e67 to
2d45212
Compare
|
If you update the instruction appendix once more, I think this'll be ready to be merged! |
|
Iam stucked with this error |
|
I think the relevant message got cut off; it's going to be above the backtrace |
|
CI is failing due to:
This may be explained by the |
|
I think this one is the main one |
Signed-off-by: Shehroz Kashif <[email protected]>
4a10748 to
0ff2f67
Compare
|
here the complete one |
AFOliveira
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shehrozkashif Seems like the only thing preventing you from merging is actually updating the golden.adoc? Are you aware how to update this file? Just copy/paste your new instructions.adoc. If you need any help, just reach out!
|
@AFOliveira Im getting the same error while running |
Thats not the error that appears in CI |
I hit a similar problem today, fixed via: And then run whatever you ran before. The "clean" task can be very handy, especially for unexpected failures. |
|
needs @dhower-qc approval to merge |
dhower-qc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sticking with this one!!
This PR adds the Zclsd extension to the database. Zclsd introduces compressed load/store pair instructions for RV32 by reusing RV64-only instruction encodings, which helps improve code density and performance when leveraging a wider than XLEN memory interface. It defines 16-bit instruction encodings and utilizes the same even-odd register pairing as the Zdinx extension. Additionally, Zclsd depends on the Zilsd and Zca extensions, and it is incompatible with Zcf due to overlapping encodings
Closes #572