Skip to content

Conversation

@omsuneri
Copy link
Contributor

this PR resolves issue #827 by moving the Zclsd constraint from the operation() function to the instruction-level definedBy field in c.ld.yaml, improving visibility for downstream tools such as disassemblers that do not evaluate operation() logic

why not used the suggested schema format?

definedBy:
  RV32:
    name: Zclsd
  RV64:
    anyOf:
      - name: C
      - name: Zca

This format is not valid under the current inst_schema.json constraints. Specifically, definedBy only supports string, anyOf, allOf, oneOf, or not constructs based on requires_entry, and does not allow architecture-specific keys like RV32 or RV64 So this approach had to be adapted within the allowed schema

@omsuneri
Copy link
Contributor Author

@ThinkOpenly please review the changes and if you want me to follow the suggested format thats in your comment please ask me to do i ll try to update the schema_defs.json.

@dhower-qc
Copy link
Collaborator

Thanks! This is a great suggestion. So good, in fact, that it is being enabled by #891 😄.

Once 891 is in main, we can make the change.

@dhower-qc
Copy link
Collaborator

closing, in favor of #891. Feel free to reopen if you want changes after 891 is in.

@dhower-qc dhower-qc closed this Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants