fix: seperated for RV32/RV64 in instruction generating schema #994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivansh-bhatnagar18
requested review from
ThinkOpenly and
dhower-qc
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dhower-qc
requested changes
Aug 18, 2025
Collaborator
dhower-qc
left a comment
dhower-qc
left a comment
There was a problem hiding this comment.
Changing the schema file alone is not sufficient. We would also need to change all the tools that read the data files.
There would also need to be a test added, and at least on use of the split in the database.
In this particular case, the issue will be solved by #891. I need to get that in soon, and would welcome your feedback on a review when it is ready.
Collaborator
|
duplicate of #891 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
definedBywas defined commonly for both RV32/RV64. The schema has been changed to allow accepting different extensions for both the configurations in both the ways whichever is convenientdefinedBy: RV32: not: I RV64: allOf: [I, Zicsr]*Just a representation
fixes #986