Added Any to list of bases and changed test to get coverage.#207
Merged
james-ball-qualcomm merged 1 commit intomainfrom Mar 11, 2026
Merged
Added Any to list of bases and changed test to get coverage.#207james-ball-qualcomm merged 1 commit intomainfrom
james-ball-qualcomm merged 1 commit intomainfrom
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for representing a “catch-all” base ISA by introducing "Any" as a valid base value in the shared schema, and updates the normative-rule golden tests to exercise that value.
Changes:
- Extend
schemas/common-schema.jsonbase enum to include"Any". - Update
tests/norm-rule/test-ch1.yamlto useinstance: Anyfor theall_basesbase rule. - Refresh expected normative-rules JSON/HTML outputs to match the new test input.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/norm-rule/test-ch1.yaml | Updates base rule input to use instance: Any. |
| tests/norm-rule/expected/test-norm-rules.json | Updates golden JSON to expect "instances": ["Any"] for the affected rule. |
| tests/norm-rule/expected/test-norm-rules.html | Updates golden HTML to display Any and label it as an instance (single item). |
| schemas/common-schema.json | Adds "Any" to the allowed base values enum. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple change.