Added better test for any base#208
Merged
james-ball-qualcomm merged 1 commit intomainfrom Mar 12, 2026
Merged
Conversation
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the parameters and normative-rules test fixtures to explicitly cover the "Any" base instance, and adjusts the generated parameters HTML to reflect that the column contains base instances as well as extension instances.
Changes:
- Update
create_params.pyHTML output to label and style the “Bases/Extensions” column (previously “Extension(s)”). - Add a new test parameter (
ALL_BASES) that references a base-kind normative rule withinstance: Any. - Update expected JSON/HTML/tag-fixture outputs for params and normative rules to include the new case and tag text.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tools/create_params.py | Renames the “extensions” column to “bases/extensions” in generated parameters HTML and updates variable naming accordingly. |
| tests/params/test-ch1.yaml | Adds ALL_BASES parameter definition to exercise the "Any" base instance case. |
| tests/params/expected/test-params.json | Updates expected params JSON to include ALL_BASES and its resolved normative rule entry. |
| tests/params/expected/test-params.html | Updates expected params HTML (counts, column header/class, and new row). |
| tests/norm-rule/test-ch1.yaml | Adds/renames a base normative rule entry for instance: Any and associates it with a tag. |
| tests/norm-rule/test-ch1.adoc | Adds the norm:all-bases anchor text used by the new tag. |
| tests/norm-rule/expected/test-norm-rules.json | Updates expected normative rules JSON for renamed rule and included tag content. |
| tests/norm-rule/expected/test-norm-rules.html | Updates expected normative rules HTML to include the new tag row and adjusted rowspans/IDs. |
| tests/norm-rule/expected/test-ch1-norm-tags.json | Adds the expected tag extraction for norm:all-bases. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.