Skip to content

Added better test for any base#208

Merged
james-ball-qualcomm merged 1 commit intomainfrom
add-better-test-for-any-base
Mar 12, 2026
Merged

Added better test for any base#208
james-ball-qualcomm merged 1 commit intomainfrom
add-better-test-for-any-base

Conversation

@james-ball-qualcomm
Copy link
Collaborator

No description provided.

Signed-off-by: James Ball <jameball@qti.qualcomm.com>
Copilot AI review requested due to automatic review settings March 11, 2026 23:15
@james-ball-qualcomm james-ball-qualcomm self-assigned this Mar 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the parameters and normative-rules test fixtures to explicitly cover the "Any" base instance, and adjusts the generated parameters HTML to reflect that the column contains base instances as well as extension instances.

Changes:

  • Update create_params.py HTML output to label and style the “Bases/Extensions” column (previously “Extension(s)”).
  • Add a new test parameter (ALL_BASES) that references a base-kind normative rule with instance: Any.
  • Update expected JSON/HTML/tag-fixture outputs for params and normative rules to include the new case and tag text.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tools/create_params.py Renames the “extensions” column to “bases/extensions” in generated parameters HTML and updates variable naming accordingly.
tests/params/test-ch1.yaml Adds ALL_BASES parameter definition to exercise the "Any" base instance case.
tests/params/expected/test-params.json Updates expected params JSON to include ALL_BASES and its resolved normative rule entry.
tests/params/expected/test-params.html Updates expected params HTML (counts, column header/class, and new row).
tests/norm-rule/test-ch1.yaml Adds/renames a base normative rule entry for instance: Any and associates it with a tag.
tests/norm-rule/test-ch1.adoc Adds the norm:all-bases anchor text used by the new tag.
tests/norm-rule/expected/test-norm-rules.json Updates expected normative rules JSON for renamed rule and included tag content.
tests/norm-rule/expected/test-norm-rules.html Updates expected normative rules HTML to include the new tag row and adjusted rowspans/IDs.
tests/norm-rule/expected/test-ch1-norm-tags.json Adds the expected tag extraction for norm:all-bases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@james-ball-qualcomm james-ball-qualcomm merged commit 1108f25 into main Mar 12, 2026
6 checks passed
@james-ball-qualcomm james-ball-qualcomm deleted the add-better-test-for-any-base branch March 12, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants