Fix spacing and sorting of allowed values in impldef_category_to_csr_category error message#229
Merged
james-ball-qualcomm merged 2 commits intoadd_warl_wlrlfrom Mar 24, 2026
Merged
Conversation
Merged
…_category error message Co-authored-by: james-ball-qualcomm <140646808+james-ball-qualcomm@users.noreply.github.com> Agent-Logs-Url: https://github.com/riscv/docs-resources/sessions/a2836ff9-8d04-4f89-afb6-07356b5b3405
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on "Add warl wlrl" PR
Fix spacing and sorting of allowed values in impldef_category_to_csr_category error message
Mar 24, 2026
james-ball-qualcomm
approved these changes
Mar 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Improves the readability and determinism of the error message emitted by impldef_category_to_csr_category in tools/shared_utils.py when an unknown impl-def-category is provided, by formatting the list of allowed values with consistent spacing and ordering.
Changes:
- Format allowed impl-def-category values with
", ".join(...)instead of",".join(...). - Sort allowed values before displaying them to keep error output stable across runs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error messages from
impldef_category_to_csr_categoryjoined allowed values with",", producing unreadable output likeWARL,WLRL.Change
tools/shared_utils.py: Use", ".join(sorted(...))instead of",".join(...)so error output readsWARL, WLRL— spaced and consistently ordered.💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.