Skip to content

Add Zicfilp extension tests#413

Open
ved-rivos wants to merge 14 commits intoriscv:devfrom
ved-rivos:zicfilp
Open

Add Zicfilp extension tests#413
ved-rivos wants to merge 14 commits intoriscv:devfrom
ved-rivos:zicfilp

Conversation

@ved-rivos
Copy link
Contributor

@ved-rivos ved-rivos commented Nov 28, 2023

Description

Implements tests for Zicfilp extension. The tests check the landing pads in M/S/U mode.
Specification: https://github.com/riscv/riscv-cfi/blob/main/cfi_forward.adoc
The arch_test.h is updated to add a landing pad - auipc x0, 0 - in the common_[MODE]_entry since a M->M transfer does a indirect branch to this entrypoint which requires a landing pad if the extension is enabled for use in M-mode. When the extension is not enable the instruction is a nop and hence can be unconditionally added.

Related Issues

N/A

Ratified/Unratified Extensions

  • Ratified
  • Unratified

List Extensions

Zicfilp: https://github.com/riscv/riscv-cfi/blob/main/cfi_forward.adoc

Reference Model Used

  • SAIL
  • Spike
  • Other - < SPECIFY HERE >

Mandatory Checklist:

  • All tests are compliant with the test-format spec present in this repo ?
  • Ran the new tests on RISCOF with SAIL/Spike as reference model successfully ?
  • Ran the new tests on RISCOF in coverage mode
  • Link to Google-Drive folder containing the new coverage reports (See this for more info): < SPECIFY HERE >
  • Link to PR in RISCV-ISAC from which the reports were generated : < SPECIFY HERE >
  • Changelog entry created with a minor patch

Optional Checklist:

  • RISCV-V CTG PR link if tests were generated using it : Add unratified Zicfilp extension riscv-software-src/riscv-ctg#93
  • Were the tests hand-written/modified ?
  • Have you run these on any hard DUT model ? Please specify name and provide link if possible in the description
  • If you have modified arch_test.h Please provide a detailed description of the changes in the Description section above.

@jamesbeyond jamesbeyond changed the base branch from main to dev May 28, 2024 16:56
@ved-rivos ved-rivos changed the title Add unratified Zicfilp extension tests Add Zicfilp extension tests Jul 3, 2024
Signed-off-by: Umer Shahid <umer.shahid@10xengineers.ai>
Signed-off-by: Umer Shahid <umer.shahid@10xengineers.ai>
@UmerShahidengr
Copy link
Collaborator

@ved-rivos thank you for your work, but as I said before, we are switching to our new framework and all tests will be re-written based on the new template. Also it is failing CI using Spike, so something is wrong in this. Probably new trap handler is not supporting these tests as new trap handler has alot of new indirect branches. We will close this one as soon as new tests will be available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants