these tests can be merged when sail bug issue #1239 is resolved#699
Draft
hamza-1821 wants to merge 3 commits intoriscv:devfrom
Draft
these tests can be merged when sail bug issue #1239 is resolved#699hamza-1821 wants to merge 3 commits intoriscv:devfrom
hamza-1821 wants to merge 3 commits intoriscv:devfrom
Conversation
Collaborator
|
@hamza-1821 can you update these tests for ACT4? The Sail bug has been fixed, so it should be possible to finish these tests now. |
Contributor
Author
Yes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were suppose to be part of PR 689, but they were failing either because of sail bug [issue #1239] or the difference in the sail and spike configuration. We are putting this PR in draft, until the sail bug is fixed and someone updates the configuration of sail and spike to match.