Updated InterruptsU.S based on the feedback received and cleaned it up#840
Draft
SadhviNarayanan wants to merge 3 commits intoriscv:act4from
Draft
Updated InterruptsU.S based on the feedback received and cleaned it up#840SadhviNarayanan wants to merge 3 commits intoriscv:act4from
SadhviNarayanan wants to merge 3 commits intoriscv:act4from
Conversation
Collaborator
|
Let's not push your Makefile because other people will want to be compiling different groups of tests. Just keep your change local for that. Is InterruptsU running and getting 100% coverage? How is InterruptsM? I'd suggest getting InterruptsM hitting coverage first in its loop form, then writing a generator for testgen to automatically produce it (see the Sm generator in testgen), getting it up to 100% coverage, then moving on to do the same for InterruptsU. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated InterruptsU.S based on the feedback received and made the tests more consistent with each other.