pushing pmpsm and pmpzca tests for ACT4 by hamza-1821 · Pull Request #948 · riscv/riscv-arch-test

hamza-1821 · 2026-02-18T14:26:56Z

This PR has both rv32 and rv64 tests for pmpsm and pmpzca

Makefile

tests/priv/pmp/pmp32/pmpsm_all_entries_check-03.S

tests/priv/pmp/pmp32/pmpsm_all_entires_check-03.S

jordancarlin

Beyond the labels that need to be updated, it looks like there are a few outstanding issues with the configuration settings.

Also, have you checked coverage with this version of the tests (by running make coverage --jobs $(nproc) and checking the report in work/sail-rv{32/64}-max/reports)? It looks like right now it won't run the PMP coverage because the directory name doesn't match the coverage file. The PMPSm tests need to be in a PMPSm directory so they get run against the PMPSm covergroups. Same for PMPZca tests in a PMPZca directory.

tests/priv/pmp/pmp32/pmpsm_cfg_A_all.S

tests/priv/pmp/pmp32/pmpsm_all_entries_check-03.S

tests/priv/pmp/pmp32/pmpzca_aligned_napot.S

UmerShahidengr · 2026-02-27T18:11:08Z

@hamza-1821 you are getting a conflict, and CI is still failing

hamza-1821 · 2026-02-27T18:15:33Z

@hamza-1821 you are getting a conflict, and CI is still failing

yes, haven't pushed the latest changes yet. That will resolve CI issue. Still working on it.

At this point, the repo holds a number of different projects that all require different people to review things. To make organizing this easier, add issue templates that automatically apply labels for common types of issues: - CTP bugs/suggestions - CRD bugs/suggestions - Test framework bugs - Test bugs - Feature requests --------- Signed-off-by: Jordan Carlin <jordanmcarlin@gmail.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Umer Shahid <umer.shahid@10xengineers.ai>

Co-authored-by: Umer Shahid <umer.shahid@10xengineers.ai>

Signed-off-by: Hamza <humza.ali1821@gmail.com>

jordancarlin

Still haven't reviewed most of the tests, but here are more structural comments. Also still need the test directory structure to be recategorized so that coverage works.

jordancarlin · 2026-03-01T06:05:39Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

+//               attempt to lw and sw to each standard region. Read should succeed and
+//               write should fail, proving all PMP entries are usable.
+//
+// Dependencies: model_test.h, arch_test.h


This list of dependencies is outdated. Rather than trying to keep it up to date, we're probably better off just dropping it. All of the tests have the same dependencies.

jordancarlin · 2026-03-01T06:06:13Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

+//
+// Notes       : - Ensure `rvmodel_macros.h` is configured to match your PMP grain
+//                 and PMP region count before running this test.
+//               - Adjust PMP configurations for specific hardware if required.


What does this note mean and how does it differ from the one above?

In the older version, there were some tests requiring pmp grain to be 0. we had checks in regex for pmp grain and pmp count for the test to be selected, and this note gives you a hint that configurations should be matched. We can remove this note in the next commit.

jordancarlin · 2026-03-01T06:06:46Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

@@ -0,0 +1,301 @@
+// --------------------------------------------------------------------------------
+// Title        : Comprehensive PMP (Physical Memory Protection) Verification


This file (and all of the PMP tests) are missing license headers. Please add an appropriate license. Most of the other tests use Apache 2.

jordancarlin · 2026-03-01T06:08:06Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

+// Set up test environment and declare main entry point
+RVTEST_BEGIN
+
+#define NOP         0x13


If this is needed, should we move it to a more central location? Maybe utils.h. Right now it is defined in all of these tests.

jordancarlin · 2026-03-01T06:08:26Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

+
+.macro VERIFICATION_RWX ADDRESS, TEST_CASE
+
+    LA(a5, \ADDRESS)                                        // Address to be ve


Comment unclear.

jordancarlin · 2026-03-01T06:17:10Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-02.S

+#ifndef RVMODEL_PMP_GRAIN
+    #define RVMODEL_PMP_GRAIN 4
+#endif
+
+#ifndef RVMODEL_NUM_PMPS
+    #define RVMODEL_NUM_PMPS 64
+#endif


Looks like this was removed from some but not all of the tests. Please double check to make sure it is removed from all of the tests since we are going to require the user to always define this.

Should be entirely removed now.

jordancarlin · 2026-03-01T06:20:07Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-02.S

What is the point of splitting pmpsm_all_entries_check into 4 parts? Seems like it would be easier to understand what each test does if this was kept together as a single test.

This test was split into 4 parts most probably beacause of the size of the signature region being too large for a single test. We can definitely use a single test that tests the upper pmp entries.

jordancarlin · 2026-03-01T06:25:04Z

tests/priv/pmp/pmp32/pmpsm_cfg_A_all.S

+    LI(x4, (NA4 << PMP3_CFG_SHIFT|NA4 << PMP2_CFG_SHIFT|NA4 << PMP1_CFG_SHIFT|NA4 << PMP0_CFG_SHIFT))
+    csrw pmpcfg0, x4
+    csrw pmpcfg1, x4
+    csrw pmpcfg2, x4
+    csrw pmpcfg3, x4


This test seems to be missing any kind of self-checking. We need to read back what we wrote to each CSR to make sure it holds the proper value. Look at the RVTEST_SIGUPD_CSR_WRITE macro in signature.h

Please double check all of the tests. There are likely other parts that are missing self-checking beyond this one too.

jordancarlin · 2026-03-01T06:29:54Z

tests/priv/pmp/pmp32/pmpsm_all_entries_check-01.S

+
+// Test case strings for reporting
+canary_mismatch: .string "Testcase signature canary mismatch!"
+test_1_str: .string "\"test: 1; cp: cp_pmpm64_lw\""


Fine to defer this to a follow-up PR after this one is merged, but the test strings should include the covergroup and bin in addition just the coverpoint. That will probably require the VERIFICATION_RWX macro to include the TEST_CASE number argument as part of the debug string (similar to what is already done for the labels).

jordancarlin · 2026-03-01T06:32:12Z

tests/priv/pmp/pmp32/pmpzca_aligned_off.S

+# REQUIRED_EXTENSIONS: ['I','Zca','S','Smpmp']
+# params:
+#   MXLEN: 32
+# MARCH: rv32ic_zicsr
+# CONFIG_DEPENDENT: true
+##### END_TEST_CONFIG #####
+
+// Define the name of this test file for reporting and the size of the signature region
+#define TEST_FILE "pmpzca_aligned_tor.S"
+#define SIGUPD_COUNT 50
+
+// Enable trap handler
+#define rvtest_mtrap_routine
+#define RVTEST_PRIV_TEST
+#define rvtest_strap_routine


Why do the Zca tests still require S and the rvtest_strap_routine?

might have missed the removal of strap handler from zca tests, and some sm tests. Since these tests only run in M mode, i will remove it.

hamza-1821 changed the title ~~pushing pmpsm and pmpzca tests~~ pushing pmpsm and pmpzca tests for ACT$ Feb 18, 2026

hamza-1821 changed the title ~~pushing pmpsm and pmpzca tests for ACT$~~ pushing pmpsm and pmpzca tests for ACT4 Feb 18, 2026

jordancarlin requested changes Feb 18, 2026

View reviewed changes

jordancarlin added the ACT4 Issues or PRs applicable to ACT4 label Feb 20, 2026

hamza-1821 added 11 commits February 24, 2026 04:40

pushing pmpsm and pmpzca tests

f36d692

remove accidental test pmpm_cfg_A_tor_zero

69132b4

renamed PMP tests from pmpm to pmpsm

1d2081b

reverted unintended sail.json changes

8486012

Reverted accidental Makefile changes

d1d783d

Fixed some PMP tests and renamed entries_check-03 test

4874c93

Removed typo file pmpsm_all_entires_check-03

3bffc48

Fixed codespell and formatting issues

b765d99

modified tests to pass on sail

23f36b3

pushing rv64 tests for pmpsm and zca

5300795

updateing test config

a6fda36

hamza-1821 force-pushed the act4-work branch from 77ae973 to a6fda36 Compare February 24, 2026 13:57

hamza-1821 and others added 3 commits February 25, 2026 02:48

fixed test config and added skipmepc in trap handler

e9a6ee0

pushing pmpsm tests from draft PR

16f149a

Merge branch 'act4' into act4-work

8de2efc

jordancarlin requested changes Feb 27, 2026

View reviewed changes

jordancarlin and others added 7 commits February 28, 2026 14:17

Coverpoints for SvH Cont'd (riscv#877)

55dd6d5

Co-authored-by: Umer Shahid <umer.shahid@10xengineers.ai>

updated selfchecking macro

39d05ff

Merge branch 'act4' into act4-work

90b3d6a

Signed-off-by: Hamza <humza.ali1821@gmail.com>

corrected test config for pmpsm napot legal test

5816e91

changed pmpcfg3 to pmpcfg2 in rv64 test

d32c9c7

fixed test name in test file

46cb66b

jordancarlin requested changes Mar 1, 2026

View reviewed changes

hamza-1821 added 3 commits March 1, 2026 10:52

fixed top of files, added liscense, included NOP from utils.h

d2ab3b7

added a check in pmpsm_all_entries_check.S

a7b4636

fixed unclear comment

2bd5cbd

		@@ -0,0 +1,301 @@
		// --------------------------------------------------------------------------------
		// Title : Comprehensive PMP (Physical Memory Protection) Verification


		.macro VERIFICATION_RWX ADDRESS, TEST_CASE

		LA(a5, \ADDRESS) // Address to be ve

Conversation

hamza-1821 commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jordancarlin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

UmerShahidengr commented Feb 27, 2026

Uh oh!

hamza-1821 commented Feb 27, 2026

Uh oh!

jordancarlin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hamza-1821 commented Feb 18, 2026 •

edited

Loading