Add Supervisor Domains extension and CSRs #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ravi Sahita <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 96.53% 97.08% +0.55%
==========================================
Files 10 14 +4
Lines 750 926 +176
==========================================
+ Hits 724 899 +175
- Misses 26 27 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aswaterman
reviewed
Nov 13, 2025
encoding.h
Outdated
Comment on lines
165
to
177
| #define MIE_SSIE (1 << IRQ_S_SOFT) | ||
| #define MIE_VSSIE (1 << IRQ_VS_SOFT) | ||
| #define MIE_MSIE (1 << IRQ_M_SOFT) | ||
| #define MIE_STIE (1 << IRQ_S_TIMER) | ||
| #define MIE_VSTIE (1 << IRQ_VS_TIMER) | ||
| #define MIE_MTIE (1 << IRQ_M_TIMER) | ||
| #define MIE_SEIE (1 << IRQ_S_EXT) | ||
| #define MIE_VSEIE (1 << IRQ_VS_EXT) | ||
| #define MIE_MEIE (1 << IRQ_M_EXT) | ||
| #define MIE_SGEIE (1 << IRQ_S_GEXT) | ||
| #define MIE_LCOFIE (1 << IRQ_LCOF) | ||
| #define MIE_MSDEIE (1 << IRQ_MSDEI) | ||
|
|
Member
There was a problem hiding this comment.
Let's get rid of this. It is a property of the ISA that MIP and MIE bits line up with each other, so having a redundant set of macros is just more code to maintain.
aswaterman
reviewed
Nov 13, 2025
encoding.h
Outdated
| #define SIP_STIP MIP_STIP | ||
| #define SIP_MSDEIP MIP_MSDEIP | ||
|
|
||
| #define SIE_MSDEIE MIE_MSDEIE |
aswaterman
reviewed
Nov 13, 2025
Member
aswaterman
left a comment
aswaterman
left a comment
There was a problem hiding this comment.
@ved-rivos can you also take a quick look? Do you agree this is stable enough that it's safe to merge?
Member
|
Thanks @rsahita! |
Signed-off-by: Ravi Sahita <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Supervisor Domains extension and CSRs