Skip to content

Remove unratified rv64_zbp dependencies from ratified extensions#401

Merged
aswaterman merged 1 commit intoriscv:masterfrom
heathdutton:338-fix-ratified-zbkb-pseudo-ops
Jan 13, 2026
Merged

Remove unratified rv64_zbp dependencies from ratified extensions#401
aswaterman merged 1 commit intoriscv:masterfrom
heathdutton:338-fix-ratified-zbkb-pseudo-ops

Conversation

@heathdutton
Copy link
Contributor

Ratified bit manipulation instructions (zip, unzip, rev8, brev8, orc.b) were defined as pseudo-ops of unratified rv64_zbp instructions. This caused issues when generating artifacts for only ratified extensions.

This PR makes these instructions standalone in their ratified extensions and updates all dependent files to reference the ratified base instructions instead.

Fixes #338

@codecov
Copy link

codecov bot commented Jan 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.08%. Comparing base (383cbca) to head (4644ba3).
⚠️ Report is 51 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #401      +/-   ##
==========================================
+ Coverage   96.53%   97.08%   +0.55%     
==========================================
  Files          10       14       +4     
  Lines         750      926     +176     
==========================================
+ Hits          724      899     +175     
- Misses         26       27       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aswaterman aswaterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had to rework Spike to account for this change, but it's an improvement.

@aswaterman aswaterman merged commit 9fd70d9 into riscv:master Jan 13, 2026
12 checks passed
aswaterman added a commit to riscv-software-src/riscv-isa-sim that referenced this pull request Jan 13, 2026
aswaterman added a commit to riscv-software-src/riscv-isa-sim that referenced this pull request Jan 13, 2026
aswaterman added a commit to riscv-software-src/riscv-isa-sim that referenced this pull request Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ratified extensions dependent on unratified extensions (bit manipulation)

2 participants