Skip to content

Fail CI if one of the jobs fail - #1571

Merged
Tim Hutt (Timmmm) merged 2 commits into
riscv:masterfrom
jordancarlin:ci_fail
Mar 3, 2026
Merged

Tim Hutt (Timmmm) merged 2 commits into
riscv:masterfrom
jordancarlin:ci_fail

Conversation

@jordancarlin

Copy link
Copy Markdown
Collaborator

Another attempt at preventing PRs that fail CI from merging. Apparently GitHub considers skipped jobs as passing, and the ci_pass job was getting skipped when one of the jobs it depended on failed.

@github-actions

github-actions Bot commented Feb 28, 2026 •

Copy link
Copy Markdown

Test Results

2 314 tests  ±0   2 314 ✅ ±0   31m 41s ⏱️ + 1m 52s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit c07a83f. ± Comparison against base commit 13d19ac.

♻️ This comment has been updated with latest results.

Comment thread .github/workflows/ci.yml
Comment thread .github/workflows/ci.yml
@Timmmm Tim Hutt (Timmmm) added the will be merged Scheduled to be merged soon if nobody objects label Mar 2, 2026
@Timmmm
Tim Hutt (Timmmm) added this pull request to the merge queue Mar 3, 2026
Merged via the queue into riscv:master with commit a0cdadb Mar 3, 2026
16 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

will be merged Scheduled to be merged soon if nobody objects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants