fix: Use run_async during update_test_file#268
Open
rkrishn7 wants to merge 1 commit intorisinglightdb:mainfrom
Open
fix: Use run_async during update_test_file#268rkrishn7 wants to merge 1 commit intorisinglightdb:mainfrom
run_async during update_test_file#268rkrishn7 wants to merge 1 commit intorisinglightdb:mainfrom
Conversation
rkrishn7
force-pushed
the
fix/update-with-retries
branch
3 times, most recently
from
debcadd to
9eb58e7
Compare
Signed-off-by: Rohan Krishnaswamy <ro@rohank.me>
rkrishn7
force-pushed
the
fix/update-with-retries
branch
from
9eb58e7 to
f264b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
update_test_filedoes not respect retry functionality. Since the expectation by the test writer is that the record will output the correct result after the retry period, we should respect it inupdate_test_file.If after the retry period the record still does not output the correct result, fallback to using
apply_record.