Skip to content

Title: Cherry-pick: Add PartitionSpec support to FileScanTask (upstream #1821) #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenzl25 merged 1 commit into from
Jan 7, 2026
Merged

Title: Cherry-pick: Add PartitionSpec support to FileScanTask (upstream #1821) #107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions crates/iceberg/src/arrow/caching_delete_file_loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -886,6 +886,9 @@ mod tests {
sequence_number: 0,
equality_ids: None,
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
};

let eq_del_scan_task = FileScanTask {
Expand All @@ -902,6 +905,9 @@ mod tests {
sequence_number: 0,
equality_ids: eq_del.equality_ids.clone(),
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
};

let file_scan_task = FileScanTask {
Expand All @@ -918,6 +924,9 @@ mod tests {
data_file_content: DataContentType::Data,
equality_ids: None,
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
};

// Load the deletes - should handle both types without error
Expand Down
4 changes: 2 additions & 2 deletions crates/iceberg/src/arrow/delete_file_loader.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ use std::sync::Arc;
use futures::{StreamExt, TryStreamExt};

use crate::arrow::ArrowReader;
use crate::arrow::record_batch_transformer::RecordBatchTransformer;
use crate::arrow::record_batch_transformer::RecordBatchTransformerBuilder;
use crate::io::FileIO;
use crate::scan::{ArrowRecordBatchStream, FileScanTaskDeleteFile};
use crate::spec::{Schema, SchemaRef};
Expand Down Expand Up @@ -82,7 +82,7 @@ impl BasicDeleteFileLoader {
equality_ids: &[i32],
) -> Result<ArrowRecordBatchStream> {
let mut record_batch_transformer =
RecordBatchTransformer::build(target_schema.clone(), equality_ids);
RecordBatchTransformerBuilder::new(target_schema.clone(), equality_ids).build();

let record_batch_stream = record_batch_stream.map(move |record_batch| {
record_batch.and_then(|record_batch| {
Expand Down
9 changes: 9 additions & 0 deletions crates/iceberg/src/arrow/delete_filter.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,6 +324,9 @@ pub(crate) mod tests {
sequence_number: 0,
equality_ids: None,
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
};

let file_scan_tasks = vec![
Expand All @@ -341,6 +344,9 @@ pub(crate) mod tests {
sequence_number: 0,
equality_ids: None,
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
},
FileScanTask {
start: 0,
Expand All @@ -356,6 +362,9 @@ pub(crate) mod tests {
sequence_number: 0,
equality_ids: None,
file_size_in_bytes: 0,
partition: None,
partition_spec: None,
name_mapping: None,
},
];

Expand Down
Loading
Loading