feat: manifest filter manager #72
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
approved these changes
Sep 17, 2025
Comment on lines
473
to
476
| let filtered_data_manifests = self | ||
| .filter_manager | ||
| .filter_manifests(&schema, existing_data_manifests) | ||
| .await?; |
There was a problem hiding this comment.
We don't need to apply filter manager against the data manifests, since filter manager is only used to choose dangling delete files for our partial compaction.
There was a problem hiding this comment.
Yeah, I think under the current framework, we don’t need to filter the data files for now. they’ve already been rewritten during the existing_manifest phase.
I will remove them
…avelabs/iceberg-rust into li0k/manifest_filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
The main goal of this PR is to remove dangling delete files to meet the requirements of partial compaction. Therefore, the filter manager is introduced to manage manifests and enable manifest rewriting.
This pull request introduces significant improvements to the transaction and snapshot management in the Iceberg Rust implementation, focusing on more robust handling of manifest files, especially for delete files. The changes include the addition of a new manifest filtering mechanism, refactoring how manifest counters are managed, and updating snapshot actions to utilize these improvements.
Manifest Filtering and Snapshot Management Enhancements:
manifest_filterto handle filtering of manifest files, and exposed its functionality for use in transactions. (crates/iceberg/src/transaction/mod.rs)SnapshotProduceActionto use a shared atomic manifest counter and introduced theManifestFilterManagerfor more sophisticated management of delete file manifests. This includes removing direct tracking of removed delete files and delegating that responsibility to the filter manager. (crates/iceberg/src/transaction/snapshot.rs) [1] [2] [3]crates/iceberg/src/transaction/snapshot.rs)new_manifest_path, improving consistency and avoiding naming conflicts. (crates/iceberg/src/transaction/snapshot.rs) [1] [2]uuidas a workspace dependency inCargo.tomlto support unique identification for manifest files. (crates/examples/Cargo.toml)These changes collectively enhance the reliability and maintainability of manifest management in Iceberg transactions, especially around handling delete files and manifest file naming.
Are these changes tested?