Skip to content

feat: add initContainers support to RisingWaveNodePodTemplateSpec #988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stex-docto wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: add initContainers support to RisingWaveNodePodTemplateSpec #988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions apis/risingwave/v1alpha1/risingwave_node_group.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,15 @@ type RisingWaveNodePodTemplateSpec struct {
// Additional containers to run in the same Pod. The containers will be appended to the Pod's containers array in order.
// + optional
AdditionalContainers []corev1.Container `json:"additionalContainers,omitempty"`

// List of initialization containers belonging to the pod.
// Init containers are executed in order prior to containers being started. If any
// init container fails, the pod is considered to have failed and is handled according
// to its restartPolicy. The name for an init container or normal container must be
// unique among all containers.
// More info: https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
// +optional
InitContainers []corev1.Container `json:"initContainers,omitempty"`
}

// RisingWaveNodePodTemplate determines the Pod specs of a RisingWave node.
Expand Down
7 changes: 7 additions & 0 deletions apis/risingwave/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38,976 changes: 23,469 additions & 15,507 deletions config/crd/bases/risingwave.risingwavelabs.com_risingwaves.yaml
View file
Open in desktop

Large diffs are not rendered by default.

38,976 changes: 23,469 additions & 15,507 deletions config/risingwave-operator-test.yaml
View file
Open in desktop

Large diffs are not rendered by default.

38,976 changes: 23,469 additions & 15,507 deletions config/risingwave-operator.yaml
View file
Open in desktop

Large diffs are not rendered by default.

38 changes: 38 additions & 0 deletions docs/general/api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3443,6 +3443,25 @@ This field is alpha-level and is only honored by servers that enable the UserNam
<p>Additional containers to run in the same Pod. The containers will be appended to the Pod&rsquo;s containers array in order.</p>
</td>
</tr>
<tr>
<td>
<code>initContainers</code><br/>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#container-v1-core">
[]Kubernetes core/v1.Container
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>List of initialization containers belonging to the pod.
Init containers are executed in order prior to containers being started. If any
init container fails, the pod is considered to have failed and is handled according
to its restartPolicy. The name for an init container or normal container must be
unique among all containers.
More info: <a href="https://kubernetes.io/docs/concepts/workloads/pods/init-containers/">https://kubernetes.io/docs/concepts/workloads/pods/init-containers/</a></p>
</td>
</tr>
</table>
</td>
</tr>
Expand Down Expand Up @@ -4012,6 +4031,25 @@ This field is alpha-level and is only honored by servers that enable the UserNam
<p>Additional containers to run in the same Pod. The containers will be appended to the Pod&rsquo;s containers array in order.</p>
</td>
</tr>
<tr>
<td>
<code>initContainers</code><br/>
<em>
<a href="https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.24/#container-v1-core">
[]Kubernetes core/v1.Container
</a>
</em>
</td>
<td>
<em>(Optional)</em>
<p>List of initialization containers belonging to the pod.
Init containers are executed in order prior to containers being started. If any
init container fails, the pod is considered to have failed and is handled according
to its restartPolicy. The name for an init container or normal container must be
unique among all containers.
More info: <a href="https://kubernetes.io/docs/concepts/workloads/pods/init-containers/">https://kubernetes.io/docs/concepts/workloads/pods/init-containers/</a></p>
</td>
</tr>
</tbody>
</table>
<h3 id="risingwave.risingwavelabs.com/v1alpha1.RisingWaveS3Credentials">RisingWaveS3Credentials
Expand Down
1 change: 1 addition & 0 deletions pkg/factory/risingwave_object_factory.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,7 @@ func newPodSpecFromNodeGroupTemplate(template *risingwavev1alpha1.RisingWaveNode
SetHostnameAsFQDN: template.Spec.SetHostnameAsFQDN,
OS: template.Spec.OS,
HostUsers: template.Spec.HostUsers,
InitContainers: template.Spec.InitContainers,
}

return podTemplateSpec
Expand Down