feat(frontend): allow users to confirm if background_ddl is enabled for a sink#24338
Merged
kwannoel merged 4 commits intorisingwavelabs:mainfrom Feb 10, 2026
Merged
Conversation
Contributor
Author
|
@kwannoel PTAL. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a background_ddl column to the rw_catalog.rw_sinks system catalog table to allow users to confirm whether background_ddl was enabled when a sink was created. This mirrors the existing background_ddl field already present in the rw_materialized_views system catalog.
Changes:
- Added
background_ddlboolean field to theRwSinkstruct in the system catalog - Populated the field by comparing
sink.create_typewithCreateType::Background - Added e2e test to verify the feature works correctly for both foreground and background sink creation
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/frontend/src/catalog/system_catalog/rw_catalog/rw_sinks.rs | Added background_ddl field to RwSink struct and populated it based on create_type |
| e2e_test/sink/check_sink_background.slt | Added e2e test validating background_ddl field for sinks created with/without background_ddl setting |
| ci/scripts/e2e-sink-test.sh | Integrated the new test into the CI test suite |
d7ac1eb to
23ef234
Compare
Standing-Man
commented
Jan 20, 2026
…or a sink Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Signed-off-by: StandingMan <jmtangcs@gmail.com>
23ef234 to
474c4d4
Compare
Signed-off-by: StandingMan <jmtangcs@gmail.com>
Contributor
Author
|
Hi @kwannoel, please take a look when you have time. |
kwannoel
approved these changes
Feb 10, 2026
Merged
via the queue into
risingwavelabs:main
with commit Feb 10, 2026
84d1225
34 of 35 checks passed
Li0k
pushed a commit
that referenced
this pull request
Feb 24, 2026
…or a sink (#24338) Signed-off-by: StandingMan <jmtangcs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note