Skip to content

Conversation

@tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

as title

follow #23654

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • I have checked the Release Timeline and Currently Supported Versions to determine which release branches I need to cherry-pick this PR into.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the A-test Area: Testing framework & misc tests not belonging to any specific component. label Jan 6, 2026
Copy link
Contributor

@zwang28 zwang28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you so much!

@zwang28 zwang28 added this pull request to the merge queue Jan 8, 2026
// When a new metadata table is added to `risingwave_meta_model` (i.e., a new `pub mod xxx;`),
// we should decide whether it needs to be included in meta snapshot v2.
//
// - If yes: append it to `for_all_metadata_models_v2` in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And insert_models before this line. I'll update the comment in another PR.

Merged via the queue into main with commit 303c78d Jan 8, 2026
33 of 34 checks passed
@zwang28 zwang28 deleted the tab/check-metadata branch January 8, 2026 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test Area: Testing framework & misc tests not belonging to any specific component.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants