Fix #4290 beam span crash by switching to shared_ptr#4291
Closed
infojunkie wants to merge 1 commit intorism-digital:developfrom
Closed
Fix #4290 beam span crash by switching to shared_ptr#4291infojunkie wants to merge 1 commit intorism-digital:developfrom
infojunkie wants to merge 1 commit intorism-digital:developfrom
Conversation
Contributor
|
Thanks. I still want to find where the pointer is not handled correctly. |
Contributor
|
I fixed it. It was missing an override of the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4290 beam span crash in expansion, by switching to
shared_ptrwhich takes care of reference counting the pointers and deleting them.