Remove overly strict stderr.is_empty() check #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands like osascript and shutdown may write informational messages to stderr even on success. The stderr.is_empty() check caused these successful operations to be incorrectly reported as failures. Only check output.status.success() to determine command outcome. Closes risoflora#20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
invoke_script()(macOS) andrun_command()(Linux) checkoutput.status.success() && output.stderr.is_empty(), which incorrectly treats successful commands as failures when they write informational messages to stderr. Removed thestderr.is_empty()condition.Closes #20
Test plan
cargo check --target aarch64-apple-darwinpasses