Add empty session_id guard in logout() fallback #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When get_session_id() returns an empty string, the fallback `loginctl kill-session ""` would always fail. Return a clear error instead of silently calling loginctl with an empty argument. Closes risoflora#21
fasuizu-br
force-pushed
the
fix/issue-21-empty-session-id
branch
from
c139770 to
146e831
Compare
AdrianEddy
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When
get_session_id()returns an empty string,logout()skips the D-BusTerminateSessioncall but still falls through tologinctl kill-session "", which always fails. Added an early return with a clear error message whensession_idis empty.Closes #21
Test plan
cargo check --target aarch64-apple-darwinpasses