Conversation
HayesGordon
reviewed
Oct 29, 2025
| "eslint-plugin-prettier": "^5.2.3", | ||
| "jest": "^29.7.0", | ||
| "nitro-codegen": "^0.25.2", | ||
| "nitrogen": "^0.31.3", |
Contributor
There was a problem hiding this comment.
nice, i remember seeing somewhere that this name might change
HayesGordon
reviewed
Oct 29, 2025
HayesGordon
reviewed
Oct 29, 2025
HayesGordon
reviewed
Oct 29, 2025
| run: | | ||
| yarn nitrogen | ||
| if ! git diff --exit-code nitrogen/generated/; then | ||
| echo "Error: nitrogen/generated/ is out of date. Please run 'yarn nitrogen' and commit the changes." |
HayesGordon
approved these changes
Oct 29, 2025
Contributor
HayesGordon
left a comment
HayesGordon
left a comment
There was a problem hiding this comment.
LGTM! Couple comments about whether we can use name or combine the dispose call for all resource cleanup
mfazekas
added a commit
that referenced
this pull request
Nov 17, 2025
…rated in git (#2) * chore: include nitro generated files in repo * chore: upgrade ios and android runtime * chore: upgrade nitro-modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
androidx.core:core,