refactor: use enums for aligment use union for properties#3
Merged
Conversation
HayesGordon
reviewed
Oct 30, 2025
| target?: string; | ||
| } | ||
|
|
||
| export type RiveEvent = { |
Contributor
There was a problem hiding this comment.
This is really nice. I always forget TypeScript can do this.
HayesGordon
reviewed
Oct 30, 2025
| @@ -0,0 +1,15 @@ | |||
| import Foundation | |||
|
|
|||
| extension EventPropertiesOutput { | |||
mfazekas
added a commit
that referenced
this pull request
Nov 17, 2025
* refactor: use enums for aligment use union for properties * fix(api): use RiveEvent union for TS side and UnifiedRiveEvent struct for native side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
properties?: Record<string, EventPropertiesOutput>;instead of AnyMapMarc suggested to use different listeners for each type. So there would be an
onURLEventononGeneralEvent, but it's a bit of a pain as we need to maintain listeners for that and remove functions, etc for every event type. But we could convert back to a single function on TS side. We can covert to that solution later.