fix(android): remove autobind from view configuration as we handle it automatically#35
Merged
HayesGordon merged 1 commit intomainfrom Nov 21, 2025
Merged
Conversation
mfazekas
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In React Native, we manually manage data binding and do not rely on Android's auto-bind property, which throws an error if the file does not have data binding.
We already have the capability to handle all the correct cases in
applyDataBindingbased on defaults and user-provided settings.Before this change, the view would propagate an error and we would not handle the correct default behaviour:
DataBindMode.Auto(default), which should not do any data binding if the file does not have any available. Can manually override by settingDataBindMode.Noneif you don't want any bindings.We handle all of this from this PR, but forgot to remove the view prop.
CleanShot.2025-11-21.at.11.14.50.mp4