chore: add support to customize ios and android sdk versions#4
Conversation
| "url": "https://github.com/rive-app/rive-nitro-react-native/issues" | ||
| }, | ||
| "homepage": "https://github.com/rive-app/rive-nitro-react-native#readme", | ||
| "runtimeVersions": { |
| def kotlin_version = getExtOrDefault("kotlinVersion") | ||
|
|
||
| def getRiveAndroidVersion() { | ||
| if (rootProject.ext.has('RiveRuntimeAndroidVersion')) { |
There was a problem hiding this comment.
When/how will this be set? Should we document this option as well?
I see on iOS we also have an environment option. Does Android need the same?
There was a problem hiding this comment.
I've looked into various libraries, some use this ext method some env variables. iOS/Podfile.properties.json, android/gradle.properties sounds the most straightforward to me considering expo, I've documented only that.
Not sure we need all 3. What do you think?
There was a problem hiding this comment.
No, I also don't think we need all the options. But is there then an argument to remove the option completely. Instead of just not documenting?
|
|
||
| rive_ios_version = nil | ||
|
|
||
| if ENV['RIVE_RUNTIME_IOS_VERSION'] |
There was a problem hiding this comment.
Should we document the environment option as well?
There was a problem hiding this comment.
Or alternatively simplify and only support one option (for now)
HayesGordon
left a comment
HayesGordon
left a comment
There was a problem hiding this comment.
LGTM! Some questions about docs and unifying iOS and Android - but likely my misunderstanding.
What do we think of exposing the same to the old Rive React Native runtime?
Yes we should do that, for sure! |
2 participants
Adds support for customizing Rive native SDK versions on iOS and Android.
package.json(runtimeVersions.iosandruntimeVersions.android)ios/Podfile.properties.jsonset"RiveRuntimeIOSVersion":"6.13.0"key. Inandroid/gradle.propertiesRive_RiveRuntimeAndroidVersion=10.6.0