feat(ns): implement namespace updates, global cache purge #2883

MasterPtato · 2025-09-08T21:13:44Z

No description provided.

vercel · 2025-09-08T21:13:49Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-cloud	Error			Sep 16, 2025 9:13am
rivet-site	Ready	Preview	Comment	Sep 16, 2025 9:13am

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
rivet-studio	Ignored	Preview		Sep 16, 2025 9:13am

claude · 2025-09-08T21:14:04Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato · 2025-09-08T21:14:05Z

feat(ns): implement namespace updates, global cache purge #2883 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

pkg-pr-new · 2025-09-08T21:14:38Z

Open in StackBlitz

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner@2883

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-runner-protocol@2883

npm i https://pkg.pr.new/rivet-gg/engine/@rivetkit/engine-tunnel-protocol@2883

commit: 3df4e46

graphite-app · 2025-09-08T21:15:44Z

packages/common/universaldb/src/atomic.rs

@@ -174,18 +174,17 @@ fn bytes_to_i64_le(bytes: &[u8]) -> i64 {
 	}

 	let mut padded = [0u8; 8];
-	let len = bytes.len().min(8);
+	let len = bytes.len();


Security Issue: Buffer Overflow Risk

There's a potential buffer overflow vulnerability in this change. The original code had a safety constraint with .min(8) that limited the number of bytes copied to the size of the padded array:

let len = bytes.len().min(8);

This constraint has been removed in the new code:

let len = bytes.len();

If bytes.len() exceeds 8, the subsequent line padded[..len].copy_from_slice(&bytes[..len]) will attempt to copy more bytes than the padded array can hold (which is fixed at 8 bytes), resulting in a buffer overflow. This would cause either a panic at runtime or memory corruption depending on the execution context.

The original .min(8) constraint should be restored to maintain memory safety.

Suggested change

let len = bytes.len();

let len = bytes.len().min(8);

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

graphite-app · 2025-09-08T21:15:45Z

packages/services/namespace/src/workflows/namespace.rs

+							}
+							RunnerKind::Custom => {
+								// Clear outbound data
+								txs.delete_key_subspace(&rivet_types::keys::pegboard::ns::OutboundDesiredSlotsKey::subspace(namespace_id));


When calling delete_key_subspace() with OutboundDesiredSlotsKey::subspace(namespace_id), there's a potential issue with the subspace targeting. Please verify that this correctly deletes all keys under the namespace's outbound desired slots. The method creates a subspace for a specific namespace, but it's important to ensure the deletion logic properly targets all relevant keys to prevent data inconsistency or orphaned records. Consider adding a test case that confirms complete cleanup of these keys when switching from Outbound to Custom runner kind.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

claude · 2025-09-08T22:44:10Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-08T22:44:13Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-09T20:30:30Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-09T20:30:31Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-11T21:33:51Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-11T21:34:46Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-14T20:01:05Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T16:48:21Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T16:49:08Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T18:06:41Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-15T18:06:52Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

claude · 2025-09-16T08:12:25Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

MasterPtato requested a review from NathanFlurry September 8, 2025 21:13

MasterPtato mentioned this pull request Sep 8, 2025

feat(pegboard): outbound runners #2873

Merged

graphite-app bot reviewed Sep 8, 2025

View reviewed changes

vercel bot deployed to Preview – rivet-site September 8, 2025 21:18 View deployment

MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from fc97845 to e2ebdb7 Compare September 8, 2025 22:43

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 3f420f5 to c376b93 Compare September 8, 2025 22:43

vercel bot deployed to Preview – rivet-site September 8, 2025 23:03 View deployment

MasterPtato mentioned this pull request Sep 9, 2025

fix: configure runner config per runner name #2891

Merged

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from c376b93 to 8b5ef7d Compare September 9, 2025 20:30

MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from e2ebdb7 to 008ff72 Compare September 9, 2025 20:30

vercel bot deployed to Preview – rivet-site September 9, 2025 20:32 View deployment

This was referenced Sep 9, 2025

chore: remove port name #2897

Merged

fix(udb): revamp udb api #2898

Merged

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 8b5ef7d to 4976f94 Compare September 11, 2025 21:33

MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from 008ff72 to 236f452 Compare September 11, 2025 21:33

This was referenced Sep 11, 2025

fix(engine/fe): remove addresses #2900

Merged

chore: cleanup, move ee changes #2901

Merged

vercel bot deployed to Preview – rivet-site September 11, 2025 21:36 View deployment

MasterPtato mentioned this pull request Sep 12, 2025

fix(api): fix query serialization for remote req #2909

Merged

MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from 236f452 to 57c4d39 Compare September 13, 2025 01:17

This was referenced Sep 13, 2025

fix(epoxy): fix Any quorum type not reaching any node #2910

Merged

feat(cloud): connect page #2912

Draft

NathanFlurry force-pushed the 09-05-feat_pegboard_outbound_runners branch from 57c4d39 to e328b2d Compare September 14, 2025 20:00

NathanFlurry force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 02c9438 to 21d608d Compare September 14, 2025 20:00

vercel bot deployed to Preview – rivet-site September 14, 2025 20:43 View deployment

vercel bot had a problem deploying to Preview – rivet-cloud September 14, 2025 20:44 Failure

NathanFlurry mentioned this pull request Sep 14, 2025

chore(runner): add alarms api #2919

Merged

jog1t force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 21d608d to 02c9438 Compare September 15, 2025 16:47

jog1t force-pushed the 09-05-feat_pegboard_outbound_runners branch from e328b2d to 57c4d39 Compare September 15, 2025 16:47

jog1t mentioned this pull request Sep 15, 2025

feat(inspector): make inspector compatible with new architecture #2920

Closed

MasterPtato force-pushed the 09-05-feat_pegboard_outbound_runners branch from 57c4d39 to 5ddcc85 Compare September 15, 2025 18:04

MasterPtato force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 02c9438 to 3df4e46 Compare September 15, 2025 18:04

This was referenced Sep 15, 2025

chore: fix api gen #2921

Merged

chore: clean up api-public #2922

Merged

vercel bot had a problem deploying to Preview – rivet-cloud September 15, 2025 18:52 Failure

vercel bot deployed to Preview – rivet-site September 15, 2025 18:54 View deployment

Base automatically changed from 09-05-feat_pegboard_outbound_runners to main September 16, 2025 08:07

feat(ns): implement namespace updates, global cache purge

012075b

NathanFlurry force-pushed the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch from 3df4e46 to 012075b Compare September 16, 2025 08:12

NathanFlurry merged commit a7bc0bc into main Sep 16, 2025
4 of 11 checks passed

NathanFlurry deleted the 09-08-feat_ns_implement_namespace_updates_global_cache_purge branch September 16, 2025 08:12

github-actions bot mentioned this pull request Sep 16, 2025

chore(main): release 25.6.1 #2851

Merged

vercel bot had a problem deploying to Preview – rivet-cloud September 16, 2025 09:10 Failure

vercel bot deployed to Preview – rivet-site September 16, 2025 09:13 View deployment

feat(ns): implement namespace updates, global cache purge #2883

feat(ns): implement namespace updates, global cache purge #2883

Uh oh!

Conversation

MasterPtato commented Sep 8, 2025

Uh oh!

vercel bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MasterPtato commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

pkg-pr-new bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

graphite-app bot Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

claude bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Sep 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

claude bot commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Sep 8, 2025 •

edited

Loading

claude bot commented Sep 8, 2025 •

edited

Loading

MasterPtato commented Sep 8, 2025 •

edited

Loading

pkg-pr-new bot commented Sep 8, 2025 •

edited

Loading

claude bot commented Sep 8, 2025 •

edited

Loading

claude bot commented Sep 8, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 9, 2025 •

edited

Loading

claude bot commented Sep 11, 2025 •

edited

Loading

claude bot commented Sep 11, 2025 •

edited

Loading

claude bot commented Sep 14, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 15, 2025 •

edited

Loading

claude bot commented Sep 16, 2025 •

edited

Loading