chore: move changes from ee #2956
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
graphite-app
bot
changed the base branch from
09-19-chore_update_nextjs_docs
to
graphite-base/2956
MasterPtato
force-pushed
the
graphite-base/2956
branch
from
e95b024 to
bbdf1c1
Compare
MasterPtato
force-pushed
the
09-19-chore_move_changes_from_ee
branch
from
bd728b2 to
588f20d
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
MasterPtato
force-pushed
the
09-19-chore_move_changes_from_ee
branch
from
588f20d to
45667b4
Compare
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
| self.informal() | ||
| .clear_subspace_range(&self.subspace.join(&subspace)); |
There was a problem hiding this comment.
There appears to be a type mismatch between the parameter types in this PR. The new delete_subspace method is using Subspace from the utils module, but the clear_subspace_range method on line 240 has been modified to accept tuple::Subspace instead of Subspace.
This creates an inconsistency where self.subspace.join(&subspace) returns a Subspace type, but clear_subspace_range now expects a tuple::Subspace.
To resolve this, either:
- Change
clear_subspace_rangeto continue acceptingSubspacetype, or - Modify the
delete_subspaceimplementation to convert totuple::Subspacebefore passing it
Maintaining type consistency will prevent potential runtime errors.
| self.informal() | |
| .clear_subspace_range(&self.subspace.join(&subspace)); | |
| self.informal() | |
| .clear_subspace_range(&tuple::Subspace::from(self.subspace.join(&subspace))); |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
Merge activity
|
No description provided.