This repository was archived by the owner on Jan 31, 2025. It is now read-only.
refactor: change breadcrumb selects to discrete variant #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hub with
|
| Latest commit: |
d895116
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e842c803.hub-3av.pages.dev |
| Branch Preview URL: | https://11-26-refactor-change-breadc.hub-3av.pages.dev |
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced Nov 26, 2024
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jog1t
force-pushed
the
11-26-feat_add_custom_icons_kit_to_rivet-gg_icons
branch
from
efe2a7d to
f59c1f8
Compare
jog1t
force-pushed
the
11-26-refactor_change_breadcrumb_selects_to_discrete_variant
branch
from
8dc3d53 to
641a5a7
Compare
This was referenced Nov 26, 2024
NicholasKissel
suggested changes
Dec 2, 2024
Member
NicholasKissel
left a comment
NicholasKissel
left a comment
There was a problem hiding this comment.
Looks good outside of the dropdown layout
Could we move the check arrow to the right side and make the team names & icons left aligned?
This was referenced Dec 8, 2024
Closed
NathanFlurry
changed the base branch from
11-26-feat_add_custom_icons_kit_to_rivet-gg_icons
to
graphite-base/410
NathanFlurry
force-pushed
the
11-26-refactor_change_breadcrumb_selects_to_discrete_variant
branch
from
641a5a7 to
d895116
Compare
NathanFlurry
force-pushed
the
graphite-base/410
branch
from
f59c1f8 to
b7c1225
Compare
Member
Merge activity
|
NicholasKissel
approved these changes
Dec 10, 2024
NathanFlurry
pushed a commit
that referenced
this pull request
Dec 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes FRONT-538