-
Notifications
You must be signed in to change notification settings - Fork 141
Adopt unified endpoint format in UI and environment variables #3736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adopt unified endpoint format in UI and environment variables #3736
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
Co-authored-by: jog1t <[email protected]>
jog1t
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot pls check also all the docs in website if they need an update
UNIFIED_ENDPOINT_ROLLOUT.md
Outdated
|
|
||
| - `frontend/src/app/publishable-token-code-group.tsx` - Code examples component | ||
| - `frontend/src/app/env-variables.tsx` - Environment variables display | ||
| - `frontend/src/routes/.../tokens.tsx` - Tokens page |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot pls remove this file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in f57fc58. Removed the UNIFIED_ENDPOINT_ROLLOUT.md file.
Updated kubernetes, aws-ecs, gcp-cloud-run, vm-and-bare-metal, ai-and-user-generated-actors, and clients/react documentation to show the unified endpoint format as the recommended approach while maintaining examples of the separate variable format for backward compatibility. Co-authored-by: jog1t <[email protected]>
Done in f57fc58. Updated all deployment documentation in the website:
All guides now present the unified endpoint format as the recommended approach while maintaining backward compatibility examples. |
|
amazing, @copilot pls make sure that internal docs also includes this change, double check if all code in the "frontend" folder contains this change. |
Updated tokens-frame.tsx and tokens page to display unified RIVET_ENDPOINT format in env var displays and copy buttons. Railway and Vercel template links kept as separate vars since they pass to external services via query params. Co-authored-by: jog1t <[email protected]>
Done in 45491a8. Completed comprehensive review of frontend folder and internal docs: Frontend Updates:
Notes:
All user-facing environment variable displays in the frontend now use the unified endpoint format. |
Updates UI code examples and environment variable displays to use the unified endpoint format
https://namespace:token@endpointinstead of separateRIVET_ENDPOINT,RIVET_NAMESPACE, andRIVET_TOKENvariables. Maintains full backward compatibility with existing separate variable format.Changes
UI Code Examples (
publishable-token-code-group.tsx)createUnifiedEndpoint()utilityEnvironment Variables (
env-variables.tsx)RivetEndpointEnvUnifiedcomponent displays unified format by defaultunifiedprop (default:true) to toggle between formatsFrontend Dialogs (
tokens-frame.tsx,tokens.tsx)Documentation
connect-backend.mdxto document both unified and separate formats with examplesRIVET_ENGINE(legacy, endpoint-only) vsRIVET_ENDPOINT(supports unified format)Example
Before:
After:
Both formats are supported by the existing endpoint parser. All deployment documentation and UI displays now present the unified format as the recommended approach while maintaining backward compatibility examples.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.