Skip to content

Conversation

@NathanFlurry
Copy link
Member

No description provided.

@railway-app
Copy link

railway-app bot commented Jan 7, 2026

🚅 Deployed to the rivet-pr-3786 environment in rivet-frontend

Service Status Web Updated (UTC)
frontend-cloud-prod 😴 Sleeping (View Logs) Web Jan 8, 2026 at 12:08 am
frontend-cloud-staging 😴 Sleeping (View Logs) Web Jan 8, 2026 at 12:08 am
frontend-inspector 😴 Sleeping (View Logs) Web Jan 8, 2026 at 12:06 am
website ❌ Build Failed (View Logs) Web Jan 7, 2026 at 11:59 pm

🚅 Deployed to the rivet-pr-3786 environment in rivet-frontend-website-preview

Service Status Web Updated (UTC)
website ❌ Build Failed (View Logs) Web Jan 7, 2026 at 11:43 pm
frontend-cloud ❌ Build Failed (View Logs) Web Jan 7, 2026 at 11:43 pm

@railway-app railway-app bot temporarily deployed to rivet-frontend-website-preview / rivet-pr-3786 January 7, 2026 23:43 Destroyed
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3786 January 7, 2026 23:43 Destroyed
Copy link
Member Author

NathanFlurry commented Jan 7, 2026


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Jan 7, 2026

PR Review: chore(ci): update pkg.pr.new for shared packages

Summary

This PR updates the pkg.pr.new CI workflow to include shared TypeScript packages and upgrades Next.js from 15.4.10 to 16.1.1 in example projects. The changes are focused on improving the package publishing process and keeping dependencies current.

Code Quality & Best Practices ✅

Positive aspects:

  • The CI workflow changes are well-targeted and follow the existing pattern
  • Proper exclusion of @rivetkit/example-registry from the build step to avoid unnecessary builds
  • Next.js upgrade follows semantic versioning appropriately
  • Lock file updates are consistent with the package.json changes

Changes Breakdown

1. CI Workflow Updates (.github/workflows/pkg-pr-new.yaml)

- pnpm build -F '@rivetkit/*'
+ pnpm build -F '@rivetkit/*' -F '!@rivetkit/example-registry'

- pnpm dlx pkg-pr-new publish 'engine/sdks/typescript/runner/' ...
+ pnpm dlx pkg-pr-new publish 'shared/typescript/*' 'engine/sdks/typescript/runner/' ...

Analysis:

  • ✅ Adding shared/typescript/* to the publish list makes sense since there's a @rivetkit/virtual-websocket package there
  • ✅ Excluding @rivetkit/example-registry from build is a good optimization
  • ✅ The workflow will now properly publish shared packages that can be used between engine and rivetkit

2. Next.js Version Bump (15.4.10 → 16.1.1)

Analysis:

  • ⚠️ Breaking Change Alert: Next.js 16 is a major version upgrade that includes breaking changes
  • ⚠️ Node.js Requirement: Next.js 16 requires Node.js >=20.9.0 (up from >=18.18.0)
  • The examples should be tested to ensure they work with Next.js 16

3. Lock File Changes (pnpm-lock.yaml)

Observations:

  • Standard lock file updates for the dependency changes
  • All Next.js platform-specific binaries updated consistently
  • Website dependencies also updated to use Next.js 16

Potential Issues & Concerns

⚠️ Testing Concerns

  1. No test evidence: There's no indication that the examples have been tested with Next.js 16
  2. Breaking changes: Next.js 16 includes significant changes that could affect:
    • App Router behavior
    • Server Components
    • Caching behavior
    • Middleware

Recommendation: Run the example projects locally to verify they still work:

cd examples/chat-room-next-js && pnpm dev
cd examples/next-js && pnpm dev

⚠️ Version File Updates

The OpenAPI and AsyncAPI version bumps (2.0.32 → 2.0.33) suggest there were API changes, but this PR is labeled as a chore. The massive additions to rivetkit-openapi/openapi.json (+445 lines) include new error handling schemas.

Questions:

  • Are these API changes intentional for this PR, or did they leak in from another branch?
  • Should this be labeled as a feature/fix rather than a chore given the API changes?

Performance Considerations ✅

  • Excluding @rivetkit/example-registry from build should improve CI performance
  • No other performance concerns identified

Security Considerations ✅

  • The new error schemas in the OpenAPI spec include proper structured error handling
  • Next.js 16 includes the latest security patches
  • No security concerns identified

Test Coverage ⚠️

  • No tests were added or modified
  • The PR should ideally include verification that:
    • Examples build successfully with Next.js 16
    • The pkg.pr.new workflow publishes shared packages correctly
    • The published packages can be installed and used

Recommendations

  1. Test the examples with Next.js 16 before merging
  2. Clarify the scope: If the OpenAPI changes are intentional, consider updating the PR description to mention them
  3. Consider splitting: If the OpenAPI changes aren't related to the CI/dependency updates, they should be in a separate PR
  4. CI verification: Ensure this PR's CI run successfully publishes all expected packages including @rivetkit/virtual-websocket

Verdict

Status: ⚠️ Approve with recommendations

The core changes are sound, but testing is needed to ensure Next.js 16 compatibility. The OpenAPI schema changes should be clarified as they seem significant for a "chore" PR.


Review generated by Claude Code

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 7, 2026

More templates

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3786

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3786

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3786

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3786

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3786

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3786

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3786

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3786

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3786

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3786

commit: 936d34d

@NathanFlurry NathanFlurry force-pushed the 01-07-chore_ci_update_pkg.pr.new_for_shared_packages branch from 4d1a4d5 to 936d34d Compare January 7, 2026 23:57
@railway-app railway-app bot temporarily deployed to rivet-frontend / rivet-pr-3786 January 7, 2026 23:57 Destroyed
@NathanFlurry NathanFlurry marked this pull request as ready for review January 8, 2026 00:01
@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 8, 2026

Merge activity

  • Jan 8, 9:33 PM UTC: NathanFlurry added this pull request to the Graphite merge queue.
  • Jan 8, 9:34 PM UTC: CI is running for this pull request on a draft pull request (#3795) due to your merge queue CI optimization settings.
  • Jan 8, 9:34 PM UTC: Merged by the Graphite merge queue via draft PR: #3795.

@graphite-app graphite-app bot closed this Jan 8, 2026
@graphite-app graphite-app bot deleted the 01-07-chore_ci_update_pkg.pr.new_for_shared_packages branch January 8, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants