Skip to content

fix(gas): dont include error iters in metric #3796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MasterPtato wants to merge 1 commit into from
Closed

fix(gas): dont include error iters in metric #3796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions engine/packages/gasoline/src/builder/workflow/lupe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ impl<'a, S: Serialize + DeserializeOwned> LoopBuilder<'a, S> {

// Used to defer loop upsertion for parallelization
let mut loop_event_upsert_fut = None;
let mut iteration_dt = Duration::ZERO;
let mut iteration_dt: Option<Duration> = None;

loop {
ctx.check_stop()?;
Expand Down Expand Up @@ -155,7 +155,7 @@ impl<'a, S: Serialize + DeserializeOwned> LoopBuilder<'a, S> {
loop_event_commit_res,
loop_event_upsert_res,
branch_commit_res,
(loop_res, cb_dt),
(cb_res, cb_dt),
) = tokio::join!(
async {
if let Some(loop_event_init_fut) = loop_event_init_fut.take() {
Expand Down Expand Up @@ -186,21 +186,23 @@ impl<'a, S: Serialize + DeserializeOwned> LoopBuilder<'a, S> {
)
.await?;

// Only record iteration duration if its not a replay
metrics::LOOP_ITERATION_DURATION
.with_label_values(&[&ctx.name().to_string()])
.observe(iteration_dt.as_secs_f64());
if let Some(iteration_dt) = &iteration_dt {
// Only record iteration duration if its not a replay
metrics::LOOP_ITERATION_DURATION
.with_label_values(&[&ctx.name().to_string()])
.observe(iteration_dt.as_secs_f64());
}
}

anyhow::Ok(())
},
async {
let iteration_start_instant = Instant::now();

(
cb(&mut iteration_branch, &mut state).await,
iteration_start_instant.elapsed(),
)
let cb_res = cb(&mut iteration_branch, &mut state).await;
let cb_dt = cb_res.is_ok().then(|| iteration_start_instant.elapsed());

(cb_res, cb_dt)
}
);

Expand All @@ -210,8 +212,7 @@ impl<'a, S: Serialize + DeserializeOwned> LoopBuilder<'a, S> {

iteration_dt = cb_dt;

// Run loop
match loop_res? {
match cb_res? {
Loop::Continue => {
iteration += 1;

Expand Down
Loading