chore: clean up errors

[MasterPtato]

No description provided.

[MasterPtato]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• fix(pegboard): cache none runner pool errors too #3899
• fix(engine-runner): handle shutdown close codes correctly #3896
• chore(gas): add overview and history docs #3879
• fix(otel): enrich http traces #3878
• fix(guard): clean up guard #3862
• fix: add ready_chunks to worker bumps, bumps per tick metric #3855
• fix(epoxy): add metrics #3847
• chore: clean up errors #3846 👈 (View in Graphite)
• fix(pb): have restart policy actors sleep after pending for too long #3837
• fix: set failure reason regardless of crash policy #3835
• feat: add metrics to pb, guard #3815
• fix: clear all pending signals after workflow complete #3798
• fix: remove pending actors metric, fix actor error tracker, engine runner error print #3797
• chore(engine): add support for epoxy debugging #3794
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

Code Review - PR #3846: chore: clean up errors

Summary

This PR cleans up error definitions by:

1. Removing unused guard.actor_destroyed and guard.actor_not_found error artifacts
2. Moving test-only errors (api_rate_limited, namespace_invalid_name) from production groups to the test group
3. Consolidating Datacenter::NotFound error from api-public to api-util (making it shared)
4. Improving error handling in guard-core tests by using anyhow::anyhow!() instead of bail!

✅ Positive Findings

Good Consolidation: Moving Datacenter::NotFound from api-public/src/errors.rs to api-util/src/errors.rs and making the errors module public is a good consolidation that reduces duplication.

Proper Test Organization: Moving test-specific errors to the test group improves organization and makes it clear these are not production errors.

Cleaner Error Handling: The change in streaming_response.rs from using bail! to explicit early return with anyhow::anyhow!() is more explicit and follows best practices.

⚠️ Issues Found

1. Dead Code in proxy_service.rs (Medium Priority)

Location: engine/packages/guard-core/src/proxy_service.rs:2530-2531

The error mappings for guard.actor_destroyed and guard.actor_not_found are still present in the code, but the error artifacts have been deleted:

("guard", "actor_not_found") => StatusCode::NOT_FOUND,
("guard", "actor_destroyed") => StatusCode::NOT_FOUND,

Issue: These mappings are now dead code since the errors no longer exist. If these errors were genuinely unused, these mappings should be removed. If they are still needed, the error artifacts should not have been deleted.

Recommendation: Either:

• Remove these two lines if the errors are truly unused, OR
• Restore the error artifacts if they are still being generated somewhere in the codebase

2. Potential Missing Import in streaming_response.rs (Low Priority)

Location: engine/packages/guard-core/tests/streaming_response.rs:256

The PR removes use anyhow::bail; but adds usage of anyhow::anyhow!(). While this works, it follows the pattern of importing the macro path rather than importing from the prelude.

Current Code:

Err(anyhow::anyhow!("bad path"))

Per CLAUDE.md Guidelines:

Do not glob import (::*) from anyhow. Instead, import individual types and traits

Recommendation: The current approach is acceptable and follows the guideline. However, for consistency with the return type (which likely comes from anyhow), consider adding:

use anyhow::anyhow;

Then use:

Err(anyhow!("bad path"))

This is a minor style point and not a blocking issue.

📋 Test Coverage

The PR updates tests in engine/packages/error/tests/basic.rs to use the new test group naming, which is correct. The error artifact files have been properly renamed to match the new structure.

Recommendation: Ensure CI passes, particularly the error tests.

🔒 Security Considerations

No security concerns identified.

⚡ Performance Considerations

No performance impact expected.

📝 Code Style & Best Practices

Follows CLAUDE.md Guidelines:

• ✅ Uses workspace dependencies appropriately
• ✅ Follows error handling patterns
• ✅ Avoids glob imports from anyhow
• ⚠️ Potential dead code remains (see Issue [SVC-2555] Set up issue templates #1)

🎯 Recommendations

1. Must Fix: Investigate the guard.actor_destroyed and guard.actor_not_found mappings in proxy_service.rs. Remove them if unused, or restore the errors if needed.

2. Nice to Have: Consider adding an explicit use anyhow::anyhow; import for consistency.

3. Verification: Ensure all tests pass, especially:

   • cargo test -p rivet-error
   • cargo test -p rivet-guard-core
   • Any integration tests that might generate these errors

Overall Assessment

The PR is mostly good with one medium-priority issue that should be addressed. The consolidation of errors and cleanup is valuable, but the dead code mappings suggest the cleanup may be incomplete.

Suggested Action: Address the dead code in proxy_service.rs before merging.

---

Review updated: 2026-01-14

[pkg-pr-new]

More templates

• actor-actions
• example-ai-agent
• example-ai-and-user-generated-actors-freestyle
• chat-room
• example-cloudflare-workers
• example-cloudflare-workers-hono
• example-cloudflare-workers-inline-client
• cross-actor-actions
• example-cursors
• example-cursors-raw-websocket
• custom-serverless
• example-sqlite
• example-elysia
• example-experimental-durable-streams-ai-agent
• hello-world
• example-hono
• hono-react
• example-kitchen-sink
• multi-region
• native-websockets
• next-js
• example-raw-fetch-handler
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-react
• scheduling
• state
• example-stream
• example-trpc

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3846

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3846

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3846

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3846

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3846

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3846

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3846

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3846

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3846

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3846

commit: a4f42a6