feat(dashboard): add agent flow to onboarding

[jog1t]

No description provided.

[jog1t]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(dashboard): add agent flow to onboarding #3987 👈 (View in Graphite)
• feat(dashboard): use vercel-flavored examples when deploying with vercel #3986
• feat(examples): add vercel examples #3985
• main

---

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[claude]

PR Review: Add Agent Flow to Onboarding

This PR adds a new onboarding flow that guides users to set up the Rivet MCP for coding agents. Overall, the implementation is solid, but there are several areas that need attention.

---

Code Quality and Best Practices

TypeScript Issues:

1. Missing spacing in type annotation (getting-started.tsx:93): flow?:Flow; should be flow?: Flow;

2. Inconsistent formatting in motion-link.tsx - Uses spaces instead of tabs

3. Unused imports in external-link-card.tsx - Slottable and cloneElement are imported but never used

4. Missing display name for MotionLinkComponent - Components created with forwardRef should have a displayName for better debugging

5. Empty object in variants (getting-started.tsx:123-126) can be removed

---

Potential Bugs

6. Commented-out URL on line 682 appears to be leftover example code and should be removed

7. Pattern matching may not cover all cases - Consider adding a catch-all .otherwise() clause to the match statement

8. Constants like claudeCode, cursorCode, installCursorUrl are defined inside component scope but could be moved outside to prevent recreating them on every render

---

Security and UX

9. External URL safety - The deep links to Cursor and VSCode use custom URI schemes. Ensure these are tested and validated. Consider adding user confirmation before opening deep links.

10. No error states or loading indicators for cases where deep links fail or coding environments are not installed

11. Missing ARIA labels for tab navigation

---

Code Organization

12. McpSetup is a 75-line component defined at the bottom of a large file. Consider extracting it to a separate file for better organization.

13. MCP_URL and MCP_NAME are hardcoded - consider moving to config or environment variables

14. Missing JSDoc comments for key functions

15. Comment quality issue (line 688): trailing comma and incomplete sentence structure

---

Testing

16. No test coverage visible for flow selection logic, MCP setup component, deep link generation, or navigation between flows

---

Recommendations

High Priority:

• Fix TypeScript spacing/formatting issues
• Remove unused imports and commented code
• Move constants outside component scope

Medium Priority:

• Extract McpSetup to separate file
• Add display name to MotionLinkComponent
• Improve comments per CLAUDE.md standards
• Add explicit fallback in pattern matching

Nice to Have:

• Add tests for new flow logic
• Improve accessibility with ARIA labels
• Add JSDoc comments
• Consider moving MCP config to environment variables

---

Summary

The feature implementation is functionally sound and adds valuable functionality for agent-based onboarding. However, the code needs cleanup for formatting consistency, removal of unused code, and better error handling. The main concerns are code quality and maintainability rather than functional correctness.

Suggested Action: Request changes to address high-priority items before merge.

[pkg-pr-new]

More templates

• actor-actions
• actor-actions-vercel
• example-ai-agent
• example-ai-agent-vercel
• example-ai-and-user-generated-actors-freestyle
• chat-room
• chat-room-vercel
• example-cloudflare-workers
• example-cloudflare-workers-hono
• cross-actor-actions
• cross-actor-actions-vercel
• example-cursors
• example-cursors-raw-websocket
• example-cursors-raw-websocket-vercel
• example-cursors-vercel
• custom-serverless
• custom-serverless-vercel
• example-sqlite
• example-sqlite-vercel
• example-elysia
• example-elysia-vercel
• example-experimental-durable-streams-ai-agent
• example-experimental-durable-streams-ai-agent-vercel
• hello-world
• hello-world-vercel
• example-hono
• hono-react
• hono-react-vercel
• example-hono-vercel
• example-kitchen-sink
• example-kitchen-sink-vercel
• multi-region
• multi-region-vercel
• native-websockets
• native-websockets-vercel
• next-js
• example-raw-fetch-handler
• example-raw-fetch-handler-vercel
• example-raw-websocket-handler
• example-raw-websocket-handler-proxy
• example-raw-websocket-handler-proxy-vercel
• example-raw-websocket-handler-vercel
• example-react
• example-react-vercel
• scheduling
• scheduling-vercel
• state
• state-vercel
• example-stream
• example-stream-vercel
• example-trpc
• example-trpc-vercel

@rivetkit/cloudflare-workers

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/cloudflare-workers@3987

@rivetkit/db

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/db@3987

@rivetkit/framework-base

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/framework-base@3987

@rivetkit/next-js

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/next-js@3987

@rivetkit/react

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/react@3987

rivetkit

pnpm add https://pkg.pr.new/rivet-dev/rivet/rivetkit@3987

@rivetkit/sql-loader

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/sql-loader@3987

@rivetkit/virtual-websocket

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/virtual-websocket@3987

@rivetkit/engine-runner

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner@3987

@rivetkit/engine-runner-protocol

pnpm add https://pkg.pr.new/rivet-dev/rivet/@rivetkit/engine-runner-protocol@3987

commit: e76f197