Support Prettier's overrides option; upgrade to Prettier 3.4.2
#12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the 3.3.0 bugfix so Prettier won't add trailing commas in Angular templates.
I forgot we need to stay compatible with better_rules_javascript's own self-formatting with Prettier, and it doesn't like the `require` syntax I was using. Therefore, we'll just support Prettier's native `overrides` by resolving for each file, and accept that it will do extra disk reads.
nevadaperry
changed the title
fileExtOverrides option handling for Prettieroverrides option
nevadaperry
changed the title
overrides optionoverrides option; upgrade to Prettier 3.4.2
nevadaperry
commented
Dec 17, 2024
| } | ||
|
|
||
| function printValue(value: StarlarkValue, indent: string | undefined): string { | ||
| function printValue(value: StarlarkValue, indent?: string | undefined): string { |
Contributor
Author
There was a problem hiding this comment.
Fixes squiggle due to line 67 printValue(k) with one arg
nevadaperry
commented
Dec 17, 2024
| const options: Options = { | ||
| ...resolvedConfig, | ||
| plugins: this.plugins, | ||
| }; |
Contributor
Author
There was a problem hiding this comment.
Have to call resolveConfig per file so Prettier will apply overrides
pauldraper
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.