This repository was archived by the owner on Jan 19, 2022. It is now read-only.
Remove override of play() method to fix player issue on Krypton (v17)#29
Open
islamelnabarawy wants to merge 1 commit intorivy:masterfrom
Open
Remove override of play() method to fix player issue on Krypton (v17)#29islamelnabarawy wants to merge 1 commit intorivy:masterfrom
islamelnabarawy wants to merge 1 commit intorivy:masterfrom
Conversation
|
Worked for me. I found the file pandaplayer.py in the addons folder and commented out the section (the two lines that were not already comments) and the plugin now works again on Kodi 17.3 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The play() method override is no longer necessary and the player works fine without it (tested on Kodi 17.3 on Windows).
Fixes #28 and #23