Add filter options menu to QuickFilterView and ComboQuickFilterView (#2230)#3582
Add filter options menu to QuickFilterView and ComboQuickFilterView (#2230)#3582RealAhmedKhairi wants to merge 1 commit intorizinorg:devfrom
Conversation
b6937ea to
4bf8965
Compare
|
@wargio I have cleaned everything up. |
wargio
left a comment
There was a problem hiding this comment.
I feel like the code repeats itself, maybe this could go into a class? @notxvilka what do you think?
Agreed, See #3580 it moves the old duplicate logic in both to a new class |
4bf8965 to
22b6079
Compare
|
@PremadeS What do I have to do now? |
|
None of the options work, because there is no logic to handle case sensitive, exact match etc |
Keep it as it is, just make sure it works |
|
@PremadeS I am sorry, I have been a little busy with my college midterms. I will start working on the functionality as soon as possible. |
22b6079 to
772df1e
Compare
faa6bc1 to
e3f5e62
Compare
4b0a0c1 to
6312258
Compare
|
@PremadeS I will start working on making CI green. |

I've read the guidelines for contributing to this repository
I made sure to follow the project's coding style
I've used AI tools to generate fully or partially these code changes and I'm sure the changes are not copyrighted by somebody else.
I've updated the documentation with the relevant information (if needed)
Detailed description
Previously, there was no way to filter quick searches. Users had no menu to toggle certain settings when searching. I have added this menu in
QuickFilterViewandComboQuickFilterViewwidgets as requested in #2230.I have read
SearchBarWidgetto understand the requirements of the issue and started working right after, The menu I have created is a line-edit menu instead of creating a separate button. I have achieved this usingQLineEdit::addAction()as advised by one of the maintainers.Changes Made
src/widgets/QuickFilterView.h: Added member variables, new signal, and helper methodsrc/widgets/QuickFilterView.cpp: Implemented menu creation and filter logicsrc/widgets/ComboQuickFilterView.h: Same additions for consistencysrc/widgets/ComboQuickFilterView.cpp: Same implementation for consistencyReferences
Inspired by how
SearchBarWidgethandles filter optionsReferenced Qt documentation: https://doc.qt.io/qt-6/qlineedit.html#addAction
Uses
SearchOptionenum fromsrc/common/CutterSearchable.hCode follows Cutter's coding style guidelines
Test Plan
Open Cutter and load a binary
Verify the cog icon appears
Click the cog icon
Test toggling options
Verify filtering behavior
Test ComboQuickFilterView (widgets using combo box + filter)
ComboQuickFilterViewcloses #2230.