Show less entries in Omnibar by default#3592
Draft
PremadeS wants to merge 3 commits intorizinorg:devfrom
Draft
Conversation
wargio
reviewed
Mar 27, 2026
| #include <QKeyEvent> | ||
|
|
||
| namespace { | ||
| constexpr int DEFAULT_ITEM_COUNT = 100; |
Member
There was a problem hiding this comment.
maybe this should be configurable as if i use the screen in portrait mode, i may want to see more results.
Collaborator
Author
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
In binaries which contain a large amount of flags, searching through the omnibar (the universal bar at the top) becomes a pain. Typing every character initiates a search through all, potentially thousands of flags.
This PR does the following:
Ctrl + Returntriggers "Show More"Ctrl + Shift + Returntriggers "Show All"Returnjumps to the address of flag, just as beforeNote that the number of visible entries resets back to 100 when the text is changed by the user (i.e: typing more characters or deleting)
Also the results are sorted by numeric mode, meaning sym.secret.100 will be shown after sym.secret.99
Test plan (required)
View->Refresh ContentsORCtrl + RI was also thinking it would be nice to provide users with the ability to change the default 100 entries count through preferences, user might also have the option to force Show All
it would require a new tab in preferences because more customizations for other widgets might be added in the future
Media

Comparison, searching through a list of 200,000 flags
Before:
After (lag on scrolling is just the gif):

Closing issues
closes #3581