Set default width for funciton name columns#3598
Open
PremadeS wants to merge 5 commits intorizinorg:devfrom
Open
Set default width for funciton name columns#3598PremadeS wants to merge 5 commits intorizinorg:devfrom
PremadeS wants to merge 5 commits intorizinorg:devfrom
Conversation
680278e to
bfe46c3
Compare
bfe46c3 to
f554a39
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Truncates the end of function names by setting a default width for function name columns on startup
The truncation and default width can be changed in
Edit->Preferences->Interface->functionsCurrently affects Functions and Backtrace widget. Only affects Functions widget when its in Horizontal mode. Since vertical/nested mode only has the name column, it seems reasonable not to truncate it
This PR also cleans the logic for BacktraceWidget to follow the model/view architecture while moving the rizin querying logic from backtrace widget to
CutterCoreFor interface related options since there will most likely be a lot more in the future it's better to create a single signal per category so there aren't 100 signals for 100 different options. I mentioned it here because this PR refactors the signals added in Improve inefficient screen space usage #3580 to follow this approach
As much as I would like to handle elision differently such as preserving the function name instead of long mangled arguments lists, it just makes the function name more difficult to understand. Not to mention making a generic function that does elision for binaries written in different languages (C++, rust, java...) is not trivial. Maybe that's why tools like IDA follow the same approach of limiting the function name columns width
Test plan (required)
View->RefreshEdit->Preferences->InterfaceGif

Since only the column width is changed and not the displayed text, searching in quick filter should work fine
Closing issues
#1904